bug #20559 [FrameworkBundle] Avoid warming up the validator cache for non-existent class (Seldaek)

fabpot · fabpot · commit 59f99493f839 · 2016-11-21T16:13:33.000-08:00
This PR was submitted for the master branch but it was merged into the 3.2 branch instead (closes #20559). Discussion ---------- [FrameworkBundle] Avoid warming up the validator cache for non-existent class | Q | A | ------------- | --- | Branch? | master | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? |no | Tests pass? | yes | License | MIT This relates to FriendsOfSymfony/FOSUserBundle#2224 - where basically the cache warmer triggers autoloading of a class that is broken, and it then blows up. This doesn't fix the problem in itself, loading broken classes will still fail, but it allows us at least to work around it by doing: ``` "exclude-from-classmap": [ "vendor/friendsofsymfony/user-bundle/Propel/" ] ``` And then `composer dump-autoload -a` to get an authoritative classmap. That way the hasMetadataFor will return false because class_exist() won't try to load the class at all. Without the hasMetadataFor fix though, it calls getMetadataFor which throws an exception in the case the class doesn't exist. I am not sure if that's by design.. that the cache warmer would force you to have classes existing for all your validation definitions. Commits ------- cb12f22 [FrameworkBundle] Avoid warming up the validator cache for non-existent classes
diff --git a/src/Symfony/Bundle/FrameworkBundle/CacheWarmer/ValidatorCacheWarmer.php b/src/Symfony/Bundle/FrameworkBundle/CacheWarmer/ValidatorCacheWarmer.php
@@ -68,7 +68,9 @@ public function warmUp($cacheDir)
 
         foreach ($this->extractSupportedLoaders($loaders) as $loader) {
             foreach ($loader->getMappedClasses() as $mappedClass) {
-                $metadataFactory->getMetadataFor($mappedClass);
+                if ($metadataFactory->hasMetadataFor($mappedClass)) {
+                    $metadataFactory->getMetadataFor($mappedClass);
+                }
             }
         }
 
diff --git a/src/Symfony/Bundle/FrameworkBundle/Tests/Fixtures/Validation/Resources/person.xml b/src/Symfony/Bundle/FrameworkBundle/Tests/Fixtures/Validation/Resources/person.xml
@@ -15,4 +15,15 @@
             </constraint>
         </property>
     </class>
+
+    <class name="Symfony\Bundle\FrameworkBundle\Tests\Fixtures\Validation\NonExistentClass">
+        <property name="gender">
+            <constraint name="Choice">
+                <option name="choices">
+                    <value>other</value>
+                </option>
+                <option name="message">This should be ignored.</option>
+            </constraint>
+        </property>
+    </class>
 </constraint-mapping>

Original file line number	Diff line number	Diff line change
`@@ -68,7 +68,9 @@ public function warmUp($cacheDir)`
`68`	`68`
`69`	`69`	`foreach ($this->extractSupportedLoaders($loaders) as $loader) {`
`70`	`70`	`foreach ($loader->getMappedClasses() as $mappedClass) {`
`71`		`- $metadataFactory->getMetadataFor($mappedClass);`
	`71`	`+ if ($metadataFactory->hasMetadataFor($mappedClass)) {`
	`72`	`+ $metadataFactory->getMetadataFor($mappedClass);`
	`73`	`+ }`
`72`	`74`	`}`
`73`	`75`	`}`
`74`	`76`