minor #30800 [Messenger] fix review (nicolas-grekas)

nicolas-grekas · nicolas-grekas · commit 607015149581 · 2019-03-31T19:13:48.000+02:00
This PR was merged into the 4.3-dev branch. Discussion ---------- [Messenger] fix review | Q | A | ------------- | --- | Branch? | master | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Fixes my review left in #30754 /cc @weaverryan FYI Commits ------- a3de902 [Messenger] fix review
diff --git a/src/Symfony/Component/Messenger/Command/StopWorkersCommand.php b/src/Symfony/Component/Messenger/Command/StopWorkersCommand.php
@@ -65,7 +65,7 @@ protected function execute(InputInterface $input, OutputInterface $output): void
         $io = new SymfonyStyle($input, $output instanceof ConsoleOutputInterface ? $output->getErrorOutput() : $output);
 
         $cacheItem = $this->restartSignalCachePool->getItem(StopWhenRestartSignalIsReceived::RESTART_REQUESTED_TIMESTAMP_KEY);
-        $cacheItem->set(time());
+        $cacheItem->set(microtime(true));
         $this->restartSignalCachePool->save($cacheItem);
 
         $io->success('Signal successfully sent to stop any running workers.');
diff --git a/src/Symfony/Component/Messenger/Worker/StopWhenRestartSignalIsReceived.php b/src/Symfony/Component/Messenger/Worker/StopWhenRestartSignalIsReceived.php
@@ -38,14 +38,14 @@ public function __construct(WorkerInterface $decoratedWorker, CacheItemPoolInter
 
     public function run(array $options = [], callable $onHandledCallback = null): void
     {
-        $workerStartedTimestamp = time();
+        $workerStartedAt = microtime(true);
 
-        $this->decoratedWorker->run($options, function (?Envelope $envelope) use ($onHandledCallback, $workerStartedTimestamp) {
+        $this->decoratedWorker->run($options, function (?Envelope $envelope) use ($onHandledCallback, $workerStartedAt) {
             if (null !== $onHandledCallback) {
                 $onHandledCallback($envelope);
             }
 
-            if ($this->shouldRestart($workerStartedTimestamp)) {
+            if ($this->shouldRestart($workerStartedAt)) {
                 $this->stop();
                 if (null !== $this->logger) {
                     $this->logger->info('Worker stopped because a restart was requested.');
@@ -59,9 +59,10 @@ public function stop(): void
         $this->decoratedWorker->stop();
     }
 
-    private function shouldRestart(int $workerStartedAt)
+    private function shouldRestart(float $workerStartedAt)
     {
         $cacheItem = $this->cachePool->getItem(self::RESTART_REQUESTED_TIMESTAMP_KEY);
+
         if (!$cacheItem->isHit()) {
             // no restart has ever been scheduled
             return false;
