Add test for removeNoFillTranslations

jawira · jawira · commit 6878c2fefc5b · 2024-10-09T18:33:04.000+02:00
diff --git a/src/Symfony/Bundle/FrameworkBundle/Command/TranslationUpdateCommand.php b/src/Symfony/Bundle/FrameworkBundle/Command/TranslationUpdateCommand.php
@@ -19,7 +19,6 @@
 use Symfony\Component\Console\Input\InputArgument;
 use Symfony\Component\Console\Input\InputInterface;
 use Symfony\Component\Console\Input\InputOption;
-use Symfony\Component\Console\Output\ConsoleOutputInterface;
 use Symfony\Component\Console\Output\OutputInterface;
 use Symfony\Component\Console\Style\SymfonyStyle;
 use Symfony\Component\HttpKernel\KernelInterface;
diff --git a/src/Symfony/Bundle/FrameworkBundle/Tests/Command/TranslationUpdateCommandTest.php b/src/Symfony/Bundle/FrameworkBundle/Tests/Command/TranslationUpdateCommandTest.php
@@ -21,6 +21,7 @@
 use Symfony\Component\HttpKernel\KernelInterface;
 use Symfony\Component\Translation\Extractor\ExtractorInterface;
 use Symfony\Component\Translation\MessageCatalogue;
+use Symfony\Component\Translation\MessageCatalogueInterface;
 use Symfony\Component\Translation\Reader\TranslationReader;
 use Symfony\Component\Translation\Translator;
 use Symfony\Component\Translation\Writer\TranslationWriter;
@@ -79,7 +80,7 @@ public function testDumpWrongSortAndClean()
 
     public function testDumpMessagesAndCleanInRootDirectory()
     {
-        $tester = $this->createCommandTester(['messages' => ['foo' => 'foo']], [], null, [$this->translationDir.'/trans'], [$this->translationDir.'/views']);
+        $tester = $this->createCommandTester(['messages' => ['foo' => 'foo']], [], null, [$this->translationDir . '/trans'], [$this->translationDir . '/views']);
         $tester->execute(['command' => 'translation:extract', 'locale' => 'en', '--dump-messages' => true, '--clean' => true]);
         $this->assertMatchesRegularExpression('/foo/', $tester->getDisplay());
         $this->assertMatchesRegularExpression('/1 message was successfully extracted/', $tester->getDisplay());
@@ -140,10 +141,10 @@ public function testWriteMessagesForSpecificDomain()
     public function testFilterDuplicateTransPaths()
     {
         $transPaths = [
-            $this->translationDir.'/a/test/folder/with/a/subfolder',
-            $this->translationDir.'/a/test/folder/',
-            $this->translationDir.'/a/test/folder/with/a/subfolder/and/a/file.txt',
-            $this->translationDir.'/a/different/test/folder',
+            $this->translationDir . '/a/test/folder/with/a/subfolder',
+            $this->translationDir . '/a/test/folder/',
+            $this->translationDir . '/a/test/folder/with/a/subfolder/and/a/file.txt',
+            $this->translationDir . '/a/different/test/folder',
         ];
 
         foreach ($transPaths as $transPath) {
@@ -169,20 +170,60 @@ public function testFilterDuplicateTransPaths()
         $filteredTransPaths = $method->invoke($command, $transPaths);
 
         $expectedPaths = [
-            realpath($this->translationDir.'/a/different/test/folder'),
-            realpath($this->translationDir.'/a/test/folder'),
+            realpath($this->translationDir . '/a/different/test/folder'),
+            realpath($this->translationDir . '/a/test/folder'),
         ];
 
         $this->assertEquals($expectedPaths, $filteredTransPaths);
     }
 
+    /**
+     * @dataProvider removeNoFillProvider
+     */
+    public function testRemoveNoFillTranslationsMethod($noFillCounter, $messages)
+    {
+        // Preparing mock
+        $operation = $this->createMock(MessageCatalogueInterface::class);
+        $operation
+            ->method('all')
+            ->with('messages')
+            ->willReturn($messages);
+        $operation
+            ->expects($this->exactly($noFillCounter))
+            ->method('set');
+
+        // Calling private method
+        $translationUpdate = $this->createMock(TranslationUpdateCommand::class);
+        $reflection = new \ReflectionObject($translationUpdate);
+        $method = $reflection->getMethod('removeNoFillTranslations');
+        $method->setAccessible(true);
+        $method->invokeArgs($translationUpdate, [$operation]);
+    }
+
+    public function removeNoFillProvider(): array
+    {
+        return [
+            [0, []],
+            [0, ['foo' => 'foo', 'bar' => 'bar', 'baz' => 'baz']],
+            [0, ['foo' => "\0foo"]],
+            [0, ['foo' => "foo\0NoFill\0"]],
+            [0, ['foo' => "f\0NoFill\000"]],
+            [0, ['foo' => "foo", 'bar' => 'bar']],
+            [1, ['foo' => "\0NoFill\0foo"]],
+            [1, ['foo' => "\0NoFill\0foo", 'bar' => 'bar']],
+            [1, ['foo' => "foo", 'bar' => "\0NoFill\0bar"]],
+            [2, ['foo' => "\0NoFill\0foo", 'bar' => "\0NoFill\0bar"]],
+            [3, ['foo' => "\0NoFill\0foo", 'bar' => "\0NoFill\0bar", 'baz' => "\0NoFill\0baz"]],
+        ];
+    }
+
     protected function setUp(): void
     {
         $this->fs = new Filesystem();
         $this->translationDir = tempnam(sys_get_temp_dir(), 'sf_translation_');
         $this->fs->remove($this->translationDir);
-        $this->fs->mkdir($this->translationDir.'/translations');
-        $this->fs->mkdir($this->translationDir.'/templates');
+        $this->fs->mkdir($this->translationDir . '/translations');
+        $this->fs->mkdir($this->translationDir . '/templates');
     }
 
     protected function tearDown(): void
@@ -261,7 +302,7 @@ function (MessageCatalogue $catalogue) use ($writerMessages) {
             ->method('getContainer')
             ->willReturn($container);
 
-        $command = new TranslationUpdateCommand($writer, $loader, $extractor, 'en', $this->translationDir.'/translations', $this->translationDir.'/templates', $transPaths, $codePaths);
+        $command = new TranslationUpdateCommand($writer, $loader, $extractor, 'en', $this->translationDir . '/translations', $this->translationDir . '/templates', $transPaths, $codePaths);
 
         $application = new Application($kernel);
         $application->add($command);
@@ -275,8 +316,7 @@ private function getBundle($path)
         $bundle
             ->expects($this->any())
             ->method('getPath')
-            ->willReturn($path)
-        ;
+            ->willReturn($path);
 
         return $bundle;
     }
