[Form] Fix INT64 cast to float in IntegerType.

ovrflo · nicolas-grekas · commit 6b6073f68585 · 2016-03-15T16:37:19.000+01:00
diff --git a/src/Symfony/Component/Form/Extension/Core/DataTransformer/NumberToLocalizedStringTransformer.php b/src/Symfony/Component/Form/Extension/Core/DataTransformer/NumberToLocalizedStringTransformer.php
@@ -122,7 +122,11 @@ public function reverseTransform($value)
             $value = str_replace(',', $decSep, $value);
         }
 
-        $result = $formatter->parse($value, \NumberFormatter::TYPE_DOUBLE, $position);
+        if (!strstr($value, $decSep) && PHP_INT_SIZE === 8) {
+            $result = $formatter->parse($value, \NumberFormatter::TYPE_INT64, $position);
+        } else {
+            $result = $formatter->parse($value, \NumberFormatter::TYPE_DOUBLE, $position);
+        }
 
         if (intl_is_failure($formatter->getErrorCode())) {
             throw new TransformationFailedException($formatter->getErrorMessage());
diff --git a/src/Symfony/Component/Form/Tests/Extension/Core/DataTransformer/NumberToLocalizedStringTransformerTest.php b/src/Symfony/Component/Form/Tests/Extension/Core/DataTransformer/NumberToLocalizedStringTransformerTest.php
@@ -433,4 +433,11 @@ public function testReverseTransformDisallowsTrailingExtraCharactersMultibyte()
 
         $transformer->reverseTransform("12\xc2\xa0345,678foo");
     }
+
+    public function testReverseTransformBigint()
+    {
+        $transformer = new NumberToLocalizedStringTransformer(null, true);
+
+        $this->assertEquals(401657096594165125, (int) $transformer->reverseTransform((string) 401657096594165125));
+    }
 }

Original file line number	Diff line number	Diff line change
`@@ -433,4 +433,11 @@ public function testReverseTransformDisallowsTrailingExtraCharactersMultibyte()`
`433`	`433`
`434`	`434`	`$transformer->reverseTransform("12\xc2\xa0345,678foo");`
`435`	`435`	`}`
	`436`	`+`
	`437`	`+ public function testReverseTransformBigint()`
	`438`	`+ {`
	`439`	`+ $transformer = new NumberToLocalizedStringTransformer(null, true);`
	`440`	`+`
	`441`	`+ $this->assertEquals(401657096594165125, (int) $transformer->reverseTransform((string) 401657096594165125));`
	`442`	`+ }`
`436`	`443`	`}`