add upgrade path for empty_data option in TextType

peter-gribanov · peter-gribanov · commit 748c37b84233 · 2021-06-02T19:10:36.000+03:00
diff --git a/src/Symfony/Component/Form/Extension/Core/Type/TextType.php b/src/Symfony/Component/Form/Extension/Core/Type/TextType.php
@@ -27,6 +27,9 @@ public function buildForm(FormBuilderInterface $builder, array $options)
         // See https://github.com/symfony/symfony/issues/5906#issuecomment-203189375
         if ('' === $options['empty_data']) {
             $builder->addViewTransformer($this);
+        } elseif ($options['empty_data'] instanceof \Closure) {
+            // we assume that this is the default value from \Symfony\Component\Form\Extension\Core\Type\FormType::configureOptions()
+            @trigger_error(sprintf('The default value of "empty_data" option in "%s" will be changed to empty string in Symfony 6.0. Declare "NULL" as value for "empty_data" if you stil want use "NULL" as data.', __CLASS__), \E_USER_DEPRECATED);
         }
     }
 

Original file line number	Diff line number	Diff line change
`@@ -27,6 +27,9 @@ public function buildForm(FormBuilderInterface $builder, array $options)`
`27`	`27`	`// See https://github.com/symfony/symfony/issues/5906#issuecomment-203189375`
`28`	`28`	`if ('' === $options['empty_data']) {`
`29`	`29`	`$builder->addViewTransformer($this);`
	`30`	`+ } elseif ($options['empty_data'] instanceof \Closure) {`
	`31`	`+ // we assume that this is the default value from \Symfony\Component\Form\Extension\Core\Type\FormType::configureOptions()`
	`32`	`+ @trigger_error(sprintf('The default value of "empty_data" option in "%s" will be changed to empty string in Symfony 6.0. Declare "NULL" as value for "empty_data" if you stil want use "NULL" as data.', __CLASS__), \E_USER_DEPRECATED);`
`30`	`33`	`}`
`31`	`34`	`}`
`32`	`35`