bug #42659 Ignoring X-Transport header while signing email with DKIM (metaer)

fabpot · fabpot · commit 75ace35f1579 · 2021-08-20T14:13:45.000+02:00
This PR was merged into the 5.3 branch. Discussion ---------- Ignoring X-Transport header while signing email with DKIM | Q | A | ------------- | --- | Branch? | 5.3 | Bug fix? | yes | New feature? | no | Deprecations? | no | Related PR | symfony/symfony-docs#15603 | License | MIT Earlier `@fabpot` wrote in symfony/symfony-docs#15603 (comment): > Anyway, this should be fixed in the code, not in the docs. **Original problem** If we have multiple transports and use one of them, signature will contain X-Transport header by default. But email will not: https://github.com/symfony/symfony/blob/810599d2f0fd19558d140c19bc50eb4dc0021a2e/src/Symfony/Component/Mailer/Transport/Transports.php#L56 And signature will be invalid. Commits ------- b684d40 Ignoring X-Transport header while signing email with DKIM
diff --git a/src/Symfony/Component/Mime/Crypto/DkimSigner.php b/src/Symfony/Component/Mime/Crypto/DkimSigner.php
@@ -68,6 +68,7 @@ public function sign(Message $message, array $options = []): Message
             throw new InvalidArgumentException('Invalid DKIM signing algorithm "%s".', $options['algorithm']);
         }
         $headersToIgnore['return-path'] = true;
+        $headersToIgnore['x-transport'] = true;
         foreach ($options['headers_to_ignore'] as $name) {
             $headersToIgnore[strtolower($name)] = true;
         }

Original file line number	Diff line number	Diff line change
`@@ -68,6 +68,7 @@ public function sign(Message $message, array $options = []): Message`
`68`	`68`	`throw new InvalidArgumentException('Invalid DKIM signing algorithm "%s".', $options['algorithm']);`
`69`	`69`	`}`
`70`	`70`	`$headersToIgnore['return-path'] = true;`
	`71`	`+ $headersToIgnore['x-transport'] = true;`
`71`	`72`	`foreach ($options['headers_to_ignore'] as $name) {`
`72`	`73`	`$headersToIgnore[strtolower($name)] = true;`
`73`	`74`	`}`