[DependencyInjection] Added information about deprecated aliases in debug:autowiring

Anthony MARTIN · Anthony MARTIN · commit 82ce6e749c25 · 2019-02-04T18:08:05.000+01:00
| Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | none | License | MIT | Doc PR | n/a Fix and improves a bit PR #29968 and #29995
diff --git a/src/Symfony/Bundle/FrameworkBundle/CHANGELOG.md b/src/Symfony/Bundle/FrameworkBundle/CHANGELOG.md
@@ -12,6 +12,7 @@ CHANGELOG
    PHP's native `serialize()` and `unserialize()` functions. To use the
    original serialization method, set the `framework.messenger.serializer.id`
    config option to `messenger.transport.symfony_serializer`.
+ * Added information about deprecated aliases in `debug:autowiring` 
 
 4.2.0
 -----
diff --git a/src/Symfony/Bundle/FrameworkBundle/Command/DebugAutowiringCommand.php b/src/Symfony/Bundle/FrameworkBundle/Command/DebugAutowiringCommand.php
@@ -104,7 +104,12 @@ protected function execute(InputInterface $input, OutputInterface $output)
             $serviceLine = sprintf('<fg=yellow>%s</>', $serviceId);
             if ($builder->hasAlias($serviceId)) {
                 $hasAlias[$serviceId] = true;
-                $serviceLine .= ' <fg=cyan>('.$builder->getAlias($serviceId).')</>';
+                $serviceAlias = $builder->getAlias($serviceId);
+                $serviceLine .= ' <fg=cyan>('.$serviceAlias.')</>';
+
+                if ($serviceAlias->isDeprecated()) {
+                    $serviceLine .= ' - <fg=magenta>deprecated</>';
+                }
             } elseif (!$all) {
                 continue;
             }
diff --git a/src/Symfony/Component/DependencyInjection/CHANGELOG.md b/src/Symfony/Component/DependencyInjection/CHANGELOG.md
@@ -6,6 +6,7 @@ CHANGELOG
 
  * added `%env(trim:...)%` processor to trim a string value
  * added `%env(default:...)%` processor to fallback to a default value
+ * added support for deprecated aliases
 
 4.2.0
 -----
diff --git a/src/Symfony/Component/DependencyInjection/Dumper/XmlDumper.php b/src/Symfony/Component/DependencyInjection/Dumper/XmlDumper.php
@@ -227,6 +227,14 @@ private function addServiceAlias($alias, Alias $id, \DOMElement $parent)
         if (!$id->isPrivate()) {
             $service->setAttribute('public', $id->isPublic() ? 'true' : 'false');
         }
+
+        if ($id->isDeprecated()) {
+            $deprecated = $this->document->createElement('deprecated');
+            $deprecated->appendChild($this->document->createTextNode($id->getDeprecationMessage('%alias_id%')));
+
+            $service->appendChild($deprecated);
+        }
+
         $parent->appendChild($service);
     }
 
diff --git a/src/Symfony/Component/DependencyInjection/Dumper/YamlDumper.php b/src/Symfony/Component/DependencyInjection/Dumper/YamlDumper.php
@@ -155,11 +155,13 @@ private function addService(string $id, Definition $definition): string
 
     private function addServiceAlias(string $alias, Alias $id): string
     {
+        $deprecated = $id->isDeprecated() ? sprintf("        deprecated: %s\n", $id->getDeprecationMessage('%alias_id%')) : '';
+
         if ($id->isPrivate()) {
-            return sprintf("    %s: '@%s'\n", $alias, $id);
+            return sprintf("    %s: '@%s'\n%s", $alias, $id, $deprecated);
         }
 
-        return sprintf("    %s:\n        alias: %s\n        public: %s\n", $alias, $id, $id->isPublic() ? 'true' : 'false');
+        return sprintf("    %s:\n        alias: %s\n        public: %s\n%s", $alias, $id, $id->isPublic() ? 'true' : 'false', $deprecated);
     }
 
     private function addServices(): string
diff --git a/src/Symfony/Component/DependencyInjection/Loader/YamlFileLoader.php b/src/Symfony/Component/DependencyInjection/Loader/YamlFileLoader.php
@@ -354,7 +354,7 @@ private function parseDefinition($id, $service, $file, array $defaults)
                 }
 
                 if ('deprecated' === $key) {
-                    $alias->setDeprecated(true, $value);
+                    $alias->setDeprecated(true, true === $value ? null : $value);
                 }
             }
 
diff --git a/src/Symfony/Component/DependencyInjection/Tests/Fixtures/xml/deprecated_alias_definitions.xml b/src/Symfony/Component/DependencyInjection/Tests/Fixtures/xml/deprecated_alias_definitions.xml
@@ -4,7 +4,7 @@
     <service id="foo" class="Foo">
     </service>
     <service id="alias_for_foo" alias="foo">
-      <deprecated />
+      <deprecated>The "%alias_id%" service alias is deprecated. You should stop using it, as it will be removed in the future.</deprecated>
     </service>
     <service id="alias_for_foobar" alias="foobar">
       <deprecated>The "%alias_id%" service alias is deprecated.</deprecated>

Original file line number	Diff line number	Diff line change
`@@ -227,6 +227,14 @@ private function addServiceAlias($alias, Alias $id, \DOMElement $parent)`
`227`	`227`	`if (!$id->isPrivate()) {`
`228`	`228`	`$service->setAttribute('public', $id->isPublic() ? 'true' : 'false');`
`229`	`229`	`}`
	`230`	`+`
	`231`	`+ if ($id->isDeprecated()) {`
	`232`	`+ $deprecated = $this->document->createElement('deprecated');`
	`233`	`+ $deprecated->appendChild($this->document->createTextNode($id->getDeprecationMessage('%alias_id%')));`
	`234`	`+`
	`235`	`+ $service->appendChild($deprecated);`
	`236`	`+ }`
	`237`	`+`
`230`	`238`	`$parent->appendChild($service);`
`231`	`239`	`}`
`232`	`240`
Original file line number	Diff line number	Diff line change
`@@ -155,11 +155,13 @@ private function addService(string $id, Definition $definition): string`
`155`	`155`
`156`	`156`	`private function addServiceAlias(string $alias, Alias $id): string`
`157`	`157`	`{`
	`158`	`+ $deprecated = $id->isDeprecated() ? sprintf(" deprecated: %s\n", $id->getDeprecationMessage('%alias_id%')) : '';`
	`159`	`+`
`158`	`160`	`if ($id->isPrivate()) {`
`159`		`- return sprintf(" %s: '@%s'\n", $alias, $id);`
	`161`	`+ return sprintf(" %s: '@%s'\n%s", $alias, $id, $deprecated);`
`160`	`162`	`}`
`161`	`163`
`162`		`- return sprintf(" %s:\n alias: %s\n public: %s\n", $alias, $id, $id->isPublic() ? 'true' : 'false');`
	`164`	`+ return sprintf(" %s:\n alias: %s\n public: %s\n%s", $alias, $id, $id->isPublic() ? 'true' : 'false', $deprecated);`
`163`	`165`	`}`
`164`	`166`
`165`	`167`	`private function addServices(): string`
Original file line number	Diff line number	Diff line change
`@@ -354,7 +354,7 @@ private function parseDefinition($id, $service, $file, array $defaults)`
`354`	`354`	`}`
`355`	`355`
`356`	`356`	`if ('deprecated' === $key) {`
`357`		`- $alias->setDeprecated(true, $value);`
	`357`	`+ $alias->setDeprecated(true, true === $value ? null : $value);`
`358`	`358`	`}`
`359`	`359`	`}`
`360`	`360`