minor #32968 Use assertEqualsWithDelta when needed (jderusse)

nicolas-grekas · nicolas-grekas · commit 87c8561c00db · 2019-08-06T08:53:06.000+02:00
This PR was merged into the 3.4 branch. Discussion ---------- Use assertEqualsWithDelta when needed | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #32844 | License | MIT | Doc PR | NA This PR replaces deprecated paramèter `$delta` of methods `assertEquals` by the dedicated method `assertEqualsWithDelta` Commits ------- 3a0a901 Use assertEqualsWithDelta when required
diff --git a/src/Symfony/Component/HttpFoundation/Tests/CookieTest.php b/src/Symfony/Component/HttpFoundation/Tests/CookieTest.php
@@ -119,7 +119,7 @@ public function testGetExpiresTimeWithStringValue()
         $cookie = new Cookie('foo', 'bar', $value);
         $expire = strtotime($value);
 
-        $this->assertEquals($expire, $cookie->getExpiresTime(), '->getExpiresTime() returns the expire date', 1);
+        $this->assertEqualsWithDelta($expire, $cookie->getExpiresTime(), 1, '->getExpiresTime() returns the expire date');
     }
 
     public function testGetDomain()
diff --git a/src/Symfony/Component/Intl/Tests/NumberFormatter/AbstractNumberFormatterTest.php b/src/Symfony/Component/Intl/Tests/NumberFormatter/AbstractNumberFormatterTest.php
@@ -806,7 +806,7 @@ public function testParseTypeDouble($value, $expectedValue)
     {
         $formatter = $this->getNumberFormatter('en', NumberFormatter::DECIMAL);
         $parsedValue = $formatter->parse($value, NumberFormatter::TYPE_DOUBLE);
-        $this->assertEquals($expectedValue, $parsedValue, '', 0.001);
+        $this->assertEqualsWithDelta($expectedValue, $parsedValue, 0.001);
     }
 
     public function parseTypeDoubleProvider()
diff --git a/src/Symfony/Component/Stopwatch/Tests/StopwatchEventTest.php b/src/Symfony/Component/Stopwatch/Tests/StopwatchEventTest.php
@@ -73,7 +73,7 @@ public function testDuration()
         $event->start();
         usleep(200000);
         $event->stop();
-        $this->assertEquals(200, $event->getDuration(), '', self::DELTA);
+        $this->assertEqualsWithDelta(200, $event->getDuration(), self::DELTA);
 
         $event = new StopwatchEvent(microtime(true) * 1000);
         $event->start();
@@ -83,15 +83,15 @@ public function testDuration()
         $event->start();
         usleep(100000);
         $event->stop();
-        $this->assertEquals(200, $event->getDuration(), '', self::DELTA);
+        $this->assertEqualsWithDelta(200, $event->getDuration(), self::DELTA);
     }
 
     public function testDurationBeforeStop()
     {
         $event = new StopwatchEvent(microtime(true) * 1000);
         $event->start();
         usleep(200000);
-        $this->assertEquals(200, $event->getDuration(), '', self::DELTA);
+        $this->assertEqualsWithDelta(200, $event->getDuration(), self::DELTA);
 
         $event = new StopwatchEvent(microtime(true) * 1000);
         $event->start();
@@ -100,7 +100,7 @@ public function testDurationBeforeStop()
         usleep(50000);
         $event->start();
         usleep(100000);
-        $this->assertEquals(100, $event->getDuration(), '', self::DELTA);
+        $this->assertEqualsWithDelta(100, $event->getDuration(), self::DELTA);
     }
 
     public function testStopWithoutStart()
@@ -132,7 +132,7 @@ public function testEnsureStopped()
         $event->start();
         usleep(100000);
         $event->ensureStopped();
-        $this->assertEquals(300, $event->getDuration(), '', self::DELTA);
+        $this->assertEqualsWithDelta(300, $event->getDuration(), self::DELTA);
     }
 
     public function testStartTime()
@@ -149,7 +149,7 @@ public function testStartTime()
         $event->start();
         usleep(100000);
         $event->stop();
-        $this->assertEquals(0, $event->getStartTime(), '', self::DELTA);
+        $this->assertEqualsWithDelta(0, $event->getStartTime(), self::DELTA);
     }
 
     public function testInvalidOriginThrowsAnException()

Original file line number	Diff line number	Diff line change
`@@ -119,7 +119,7 @@ public function testGetExpiresTimeWithStringValue()`
`119`	`119`	`$cookie = new Cookie('foo', 'bar', $value);`
`120`	`120`	`$expire = strtotime($value);`
`121`	`121`
`122`		`- $this->assertEquals($expire, $cookie->getExpiresTime(), '->getExpiresTime() returns the expire date', 1);`
	`122`	`+ $this->assertEqualsWithDelta($expire, $cookie->getExpiresTime(), 1, '->getExpiresTime() returns the expire date');`
`123`	`123`	`}`
`124`	`124`
`125`	`125`	`public function testGetDomain()`
Original file line number	Diff line number	Diff line change
`@@ -806,7 +806,7 @@ public function testParseTypeDouble($value, $expectedValue)`
`806`	`806`	`{`
`807`	`807`	`$formatter = $this->getNumberFormatter('en', NumberFormatter::DECIMAL);`
`808`	`808`	`$parsedValue = $formatter->parse($value, NumberFormatter::TYPE_DOUBLE);`
`809`		`- $this->assertEquals($expectedValue, $parsedValue, '', 0.001);`
	`809`	`+ $this->assertEqualsWithDelta($expectedValue, $parsedValue, 0.001);`
`810`	`810`	`}`
`811`	`811`
`812`	`812`	`public function parseTypeDoubleProvider()`