minor #47704 [Stopwatch] Correct compare float data in tests (Peter Gribanov)

nicolas-grekas · nicolas-grekas · commit 89ca1c01a88b · 2022-09-28T15:02:38.000+02:00
This PR was merged into the 4.4 branch. Discussion ---------- [Stopwatch] Correct compare float data in tests | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | License | MIT  Fix erorr in unit tests ``` 1) Symfony\Component\Stopwatch\Tests\StopwatchPeriodTest::testGetDuration with data set #8 (2.71, 3.14, true, 0.43) Failed asserting that 0.43000000000000016 is identical to 0.43. ``` Commits ------- b02e251 Correct compare float data
diff --git a/src/Symfony/Component/Stopwatch/Tests/StopwatchPeriodTest.php b/src/Symfony/Component/Stopwatch/Tests/StopwatchPeriodTest.php
@@ -40,7 +40,7 @@ public function testGetEndTime($end, $useMorePrecision, $expected)
     public function testGetDuration($start, $end, $useMorePrecision, $duration)
     {
         $period = new StopwatchPeriod($start, $end, $useMorePrecision);
-        $this->assertSame($duration, $period->getDuration());
+        $this->assertEqualsWithDelta($duration, $period->getDuration(), \PHP_FLOAT_EPSILON);
     }
 
     public function provideTimeValues()
diff --git a/src/Symfony/Component/Stopwatch/composer.json b/src/Symfony/Component/Stopwatch/composer.json
@@ -19,6 +19,9 @@
         "php": ">=7.1.3",
         "symfony/service-contracts": "^1.0|^2"
     },
+    "require-dev": {
+        "symfony/polyfill-php72": "~1.5"
+    },
     "autoload": {
         "psr-4": { "Symfony\\Component\\Stopwatch\\": "" },
         "exclude-from-classmap": [

Original file line number	Diff line number	Diff line change
`@@ -40,7 +40,7 @@ public function testGetEndTime($end, $useMorePrecision, $expected)`
`40`	`40`	`public function testGetDuration($start, $end, $useMorePrecision, $duration)`
`41`	`41`	`{`
`42`	`42`	`$period = new StopwatchPeriod($start, $end, $useMorePrecision);`
`43`		`- $this->assertSame($duration, $period->getDuration());`
	`43`	`+ $this->assertEqualsWithDelta($duration, $period->getDuration(), \PHP_FLOAT_EPSILON);`
`44`	`44`	`}`
`45`	`45`
`46`	`46`	`public function provideTimeValues()`