bug #57282 [Scheduler] Throw an exception when no dispatcher has been passed to a Schedule (fabpot)

fabpot · fabpot · commit 9b50a9295738 · 2024-06-01T11:17:21.000+02:00
This PR was merged into the 6.4 branch. Discussion ---------- [Scheduler] Throw an exception when no dispatcher has been passed to a Schedule | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | yes | New feature? | no  | Deprecations? | no  | Issues | Fix #53722  | License | MIT Commits ------- dfd65d6 [Scheduler] Throw an exception when no dispatcher has been passed to a Schedule
diff --git a/src/Symfony/Component/Scheduler/Schedule.php b/src/Symfony/Component/Scheduler/Schedule.php
@@ -141,20 +141,32 @@ public function getSchedule(): static
 
     public function before(callable $listener, int $priority = 0): static
     {
+        if (!$this->dispatcher) {
+            throw new LogicException(sprintf('To register a listener with "%s()", you need to set an event dispatcher on the Schedule.', __METHOD__));
+        }
+
         $this->dispatcher->addListener(PreRunEvent::class, $listener, $priority);
 
         return $this;
     }
 
     public function after(callable $listener, int $priority = 0): static
     {
+        if (!$this->dispatcher) {
+            throw new LogicException(sprintf('To register a listener with "%s()", you need to set an event dispatcher on the Schedule.', __METHOD__));
+        }
+
         $this->dispatcher->addListener(PostRunEvent::class, $listener, $priority);
 
         return $this;
     }
 
     public function onFailure(callable $listener, int $priority = 0): static
     {
+        if (!$this->dispatcher) {
+            throw new LogicException(sprintf('To register a listener with "%s()", you need to set an event dispatcher on the Schedule.', __METHOD__));
+        }
+
         $this->dispatcher->addListener(FailureEvent::class, $listener, $priority);
 
         return $this;

Original file line number	Diff line number	Diff line change
`@@ -141,20 +141,32 @@ public function getSchedule(): static`
`141`	`141`
`142`	`142`	`public function before(callable $listener, int $priority = 0): static`
`143`	`143`	`{`
	`144`	`+ if (!$this->dispatcher) {`
	`145`	`+ throw new LogicException(sprintf('To register a listener with "%s()", you need to set an event dispatcher on the Schedule.', __METHOD__));`
	`146`	`+ }`
	`147`	`+`
`144`	`148`	`$this->dispatcher->addListener(PreRunEvent::class, $listener, $priority);`
`145`	`149`
`146`	`150`	`return $this;`
`147`	`151`	`}`
`148`	`152`
`149`	`153`	`public function after(callable $listener, int $priority = 0): static`
`150`	`154`	`{`
	`155`	`+ if (!$this->dispatcher) {`
	`156`	`+ throw new LogicException(sprintf('To register a listener with "%s()", you need to set an event dispatcher on the Schedule.', __METHOD__));`
	`157`	`+ }`
	`158`	`+`
`151`	`159`	`$this->dispatcher->addListener(PostRunEvent::class, $listener, $priority);`
`152`	`160`
`153`	`161`	`return $this;`
`154`	`162`	`}`
`155`	`163`
`156`	`164`	`public function onFailure(callable $listener, int $priority = 0): static`
`157`	`165`	`{`
	`166`	`+ if (!$this->dispatcher) {`
	`167`	`+ throw new LogicException(sprintf('To register a listener with "%s()", you need to set an event dispatcher on the Schedule.', __METHOD__));`
	`168`	`+ }`
	`169`	`+`
`158`	`170`	`$this->dispatcher->addListener(FailureEvent::class, $listener, $priority);`
`159`	`171`
`160`	`172`	`return $this;`