bug #53537 [VarDumper] Fix missing colors initialization in CliDumper (nicolas-grekas)

xabbuh · xabbuh · commit 9e74afd9bf8e · 2024-01-16T22:23:38.000+01:00
This PR was merged into the 5.4 branch. Discussion ---------- [VarDumper] Fix missing colors initialization in `CliDumper` | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | - | License | MIT Backporting #53521 to 5.4 Commits ------- 6817109 [VarDumper] Fix missing colors initialization in CliDumper
diff --git a/src/Symfony/Component/VarDumper/Dumper/CliDumper.php b/src/Symfony/Component/VarDumper/Dumper/CliDumper.php
@@ -564,6 +564,10 @@ protected function supportsColors()
      */
     protected function dumpLine(int $depth, bool $endOfValue = false)
     {
+        if (null === $this->colors) {
+            $this->colors = $this->supportsColors();
+        }
+
         if ($this->colors) {
             $this->line = sprintf("\033[%sm%s\033[m", $this->styles['default'], $this->line);
         }

Original file line number	Diff line number	Diff line change
`@@ -564,6 +564,10 @@ protected function supportsColors()`
`564`	`564`	`*/`
`565`	`565`	`protected function dumpLine(int $depth, bool $endOfValue = false)`
`566`	`566`	`{`
	`567`	`+ if (null === $this->colors) {`
	`568`	`+ $this->colors = $this->supportsColors();`
	`569`	`+ }`
	`570`	`+`
`567`	`571`	`if ($this->colors) {`
`568`	`572`	`$this->line = sprintf("\033[%sm%s\033[m", $this->styles['default'], $this->line);`
`569`	`573`	`}`