remove unnecessary css class "d-block" from form_errors

FlashBlack · FlashBlack · commit a8d74c591755 · 2019-02-11T12:50:24.000+03:00
diff --git a/src/Symfony/Bridge/Twig/Resources/views/Form/bootstrap_4_layout.html.twig b/src/Symfony/Bridge/Twig/Resources/views/Form/bootstrap_4_layout.html.twig
@@ -289,7 +289,7 @@
 
 {% block form_errors -%}
     {%- if errors|length > 0 -%}
-        <div class="{% if form is not rootform %}invalid-feedback{% else %}alert alert-danger{% endif %} d-block">
+        <div class="{% if form is not rootform %}invalid-feedback{% else %}alert alert-danger{% endif %}">
             {%- for error in errors -%}
                 <span class="d-block">
                     <span class="form-error-message">{{ error.message }}</span>
diff --git a/src/Symfony/Bridge/Twig/Tests/Extension/AbstractBootstrap4HorizontalLayoutTest.php b/src/Symfony/Bridge/Twig/Tests/Extension/AbstractBootstrap4HorizontalLayoutTest.php
@@ -34,7 +34,7 @@ public function testRow()
         /following-sibling::div[@class="col-sm-10"]
             [
                 ./input[@id="name"]
-                /following-sibling::div[@class="alert alert-danger d-block"]
+                /following-sibling::div[@class="alert alert-danger"]
                     [
                         ./span[@class="d-block"]
                             [
diff --git a/src/Symfony/Bridge/Twig/Tests/Extension/AbstractBootstrap4LayoutTest.php b/src/Symfony/Bridge/Twig/Tests/Extension/AbstractBootstrap4LayoutTest.php
@@ -41,7 +41,7 @@ public function testRow()
     [
         ./label[@for="name"]
         /following-sibling::input[@id="name"]
-        /following-sibling::div[@class="alert alert-danger d-block"]
+        /following-sibling::div[@class="alert alert-danger"]
             [
                 ./span[@class="d-block"]
                     [
@@ -288,7 +288,7 @@ public function testErrors()
         $html = $this->renderErrors($view);
 
         $this->assertMatchesXpath($html,
-'/div[@class="alert alert-danger d-block"]
+'/div[@class="alert alert-danger"]
     [
         ./span[@class="d-block"]
             [./span[.="[trans]Error 1[/trans]"]]

Original file line number	Diff line number	Diff line change
`@@ -34,7 +34,7 @@ public function testRow()`
`34`	`34`	`/following-sibling::div[@class="col-sm-10"]`
`35`	`35`	`[`
`36`	`36`	`./input[@id="name"]`
`37`		`- /following-sibling::div[@class="alert alert-danger d-block"]`
	`37`	`+ /following-sibling::div[@class="alert alert-danger"]`
`38`	`38`	`[`
`39`	`39`	`./span[@class="d-block"]`
`40`	`40`	`[`
Original file line number	Diff line number	Diff line change
`@@ -41,7 +41,7 @@ public function testRow()`
`41`	`41`	`[`
`42`	`42`	`./label[@for="name"]`
`43`	`43`	`/following-sibling::input[@id="name"]`
`44`		`- /following-sibling::div[@class="alert alert-danger d-block"]`
	`44`	`+ /following-sibling::div[@class="alert alert-danger"]`
`45`	`45`	`[`
`46`	`46`	`./span[@class="d-block"]`
`47`	`47`	`[`
`@@ -288,7 +288,7 @@ public function testErrors()`
`288`	`288`	`$html = $this->renderErrors($view);`
`289`	`289`
`290`	`290`	`$this->assertMatchesXpath($html,`
`291`		`-'/div[@class="alert alert-danger d-block"]`
	`291`	`+'/div[@class="alert alert-danger"]`
`292`	`292`	`[`
`293`	`293`	`./span[@class="d-block"]`
`294`	`294`	`[./span[.="[trans]Error 1[/trans]"]]`