bug #37558 Removed @internal from Composite (vudaltsov)

fabpot · fabpot · commit ab29e071aea4 · 2020-07-23T08:35:33.000+02:00
This PR was submitted for the master branch but it was merged into the 5.1 branch instead. Discussion ---------- Removed @internal from Composite | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | Deprecations? | no | Tickets | Fix #37348 | License | MIT I think that Composite should not be @internal. Even with the new @Compound constraint Composite is still useful for complex custom validators. For example, I have @ExcelColumn(string $column, array $constraints) that checks that all cells in a column of an uploaded Excel file are valid. This cannot be expressed with @Compound. Commits ------- 8958ce1 Removed @internal from Composite
diff --git a/src/Symfony/Component/Validator/Constraints/Composite.php b/src/Symfony/Component/Validator/Constraints/Composite.php
@@ -25,8 +25,6 @@
  * contains the nested constraints.
  *
  * @author Bernhard Schussek <bschussek@gmail.com>
- *
- * @internal since Symfony 5.1
  */
 abstract class Composite extends Constraint
 {

Original file line number	Diff line number	Diff line change
`@@ -25,8 +25,6 @@`
`25`	`25`	`* contains the nested constraints.`
`26`	`26`	`*`
`27`	`27`	`* @author Bernhard Schussek <[email protected]>`
`28`		`- *`
`29`		`- * @internal since Symfony 5.1`
`30`	`28`	`*/`
`31`	`29`	`abstract class Composite extends Constraint`
`32`	`30`	`{`