Removed @internal from Composite #37558
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @ogizanagi maybe? |
|
I don't have arguments against. What do you think @xabbuh? |
|
works for me |
ogizanagi
approved these changes
Jul 17, 2020
fabpot
approved these changes
Jul 23, 2020
f180fd3 to
8958ce1
Compare
|
Thank you @vudaltsov. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think that Composite should not be @internal. Even with the new @Compound constraint Composite is still useful for complex custom validators.
For example, I have @ExcelColumn(string $column, array $constraints) that checks that all cells in a column of an uploaded Excel file are valid. This cannot be expressed with @Compound.