minor #21488 [DI] Save a ReflectionClass instantiation in AutowirePass (nicolas-grekas)

nicolas-grekas · nicolas-grekas · commit b4ff1c87673d · 2017-02-01T15:23:38.000+01:00
This PR was merged into the 3.3-dev branch. Discussion ---------- [DI] Save a ReflectionClass instantiation in AutowirePass | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - No behavioral change, just a small refacto that I'm needing for two different PRs I'm working on - will make reviewing them easier also. Best reviewed by ignoring whitespaces. Commits ------- b893c72 [DI] Save a ReflectionClass instanciation in AutowirePass
diff --git a/src/Symfony/Component/DependencyInjection/Compiler/AutowirePass.php b/src/Symfony/Component/DependencyInjection/Compiler/AutowirePass.php
@@ -219,54 +219,69 @@ private function autowireMethod(\ReflectionMethod $reflectionMethod, array $argu
                 continue;
             }
 
-            try {
-                if (!$typeHint = $parameter->getClass()) {
-                    // no default value? Then fail
-                    if (!$parameter->isOptional()) {
-                        if ($mustAutowire) {
-                            throw new RuntimeException(sprintf('Cannot autowire service "%s": argument $%s of method %s::%s() must have a type-hint or be given a value explicitly.', $this->currentId, $parameter->name, $reflectionMethod->class, $reflectionMethod->name));
-                        }
-
-                        return array();
-                    }
+            if (method_exists($parameter, 'getType')) {
+                if ($typeName = $parameter->getType()) {
+                    $typeName = $typeName->isBuiltin() ? null : ($typeName instanceof \ReflectionNamedType ? $typeName->getName() : $typeName->__toString());
+                }
+            } elseif (preg_match('/^(?:[^ ]++ ){4}([a-zA-Z_\x7F-\xFF][^ ]++)/', $parameter, $typeName)) {
+                $typeName = 'callable' === $typeName[1] || 'array' === $typeName[1] ? null : $typeName[1];
+            }
 
-                    if (!array_key_exists($index, $arguments)) {
-                        // specifically pass the default value
-                        $arguments[$index] = $parameter->getDefaultValue();
+            if (!$typeName) {
+                // no default value? Then fail
+                if (!$parameter->isOptional()) {
+                    if ($mustAutowire) {
+                        throw new RuntimeException(sprintf('Cannot autowire service "%s": argument $%s of method %s::%s() must have a type-hint or be given a value explicitly.', $this->currentId, $parameter->name, $reflectionMethod->class, $reflectionMethod->name));
                     }
 
-                    continue;
+                    return array();
                 }
 
-                if (null === $this->types) {
-                    $this->populateAvailableTypes();
+                if (!array_key_exists($index, $arguments)) {
+                    // specifically pass the default value
+                    $arguments[$index] = $parameter->getDefaultValue();
                 }
 
-                if (isset($this->types[$typeHint->name])) {
-                    $value = new Reference($this->types[$typeHint->name]);
+                continue;
+            }
+
+            if (null === $this->types) {
+                $this->populateAvailableTypes();
+            }
+
+            if (isset($this->types[$typeName])) {
+                $arguments[$index] = new Reference($this->types[$typeName]);
+                $didAutowire = true;
+
+                continue;
+            }
+
+            try {
+                $typeHint = new \ReflectionClass($typeName);
+            } catch (\ReflectionException $e) {
+                // Typehint against a non-existing class
+                $typeHint = false;
+            }
+
+            if ($typeHint) {
+                try {
+                    $value = $this->createAutowiredDefinition($typeHint);
                     $didAutowire = true;
-                } else {
-                    try {
-                        $value = $this->createAutowiredDefinition($typeHint);
-                        $didAutowire = true;
-                    } catch (RuntimeException $e) {
-                        if ($parameter->allowsNull()) {
-                            $value = null;
-                        } elseif ($parameter->isDefaultValueAvailable()) {
-                            $value = $parameter->getDefaultValue();
-                        } else {
-                            // The exception code is set to 1 if the exception must be thrown even if it's an optional setter
-                            if (1 === $e->getCode() || $mustAutowire) {
-                                throw $e;
-                            }
-
-                            return array();
+                } catch (RuntimeException $e) {
+                    if ($parameter->allowsNull()) {
+                        $value = null;
+                    } elseif ($parameter->isDefaultValueAvailable()) {
+                        $value = $parameter->getDefaultValue();
+                    } else {
+                        // The exception code is set to 1 if the exception must be thrown even if it's an optional setter
+                        if (1 === $e->getCode() || $mustAutowire) {
+                            throw $e;
                         }
+
+                        return array();
                     }
                 }
-            } catch (\ReflectionException $e) {
-                // Typehint against a non-existing class
-
+            } else {
                 if (!$parameter->isDefaultValueAvailable()) {
                     if ($mustAutowire) {
                         throw new RuntimeException(sprintf('Cannot autowire argument $%s of method %s::%s() for service "%s": %s.', $parameter->name, $reflectionMethod->class, $reflectionMethod->name, $this->currentId, $e->getMessage()), 0, $e);
