[DI] Save a ReflectionClass instantiation in AutowirePass#21488
Merged
nicolas-grekas merged 1 commit intosymfony:masterfrom Feb 1, 2017
Merged
[DI] Save a ReflectionClass instantiation in AutowirePass#21488nicolas-grekas merged 1 commit intosymfony:masterfrom
nicolas-grekas merged 1 commit intosymfony:masterfrom
Conversation
nicolas-grekas
added a commit
that referenced
this pull request
Feb 1, 2017
…s (nicolas-grekas) This PR was merged into the 3.3-dev branch. Discussion ---------- [DI] Save a ReflectionClass instantiation in AutowirePass | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - No behavioral change, just a small refacto that I'm needing for two different PRs I'm working on - will make reviewing them easier also. Best reviewed by ignoring whitespaces. Commits ------- b893c72 [DI] Save a ReflectionClass instanciation in AutowirePass
stof
reviewed
Feb 1, 2017
| if ($typeName = $parameter->getType()) { | ||
| $typeName = $typeName->isBuiltin() ? null : ($typeName instanceof \ReflectionNamedType ? $typeName->getName() : $typeName->__toString()); | ||
| } | ||
| } elseif (preg_match('/^(?:[^ ]++ ){4}([a-zA-Z_\x7F-\xFF][^ ]++)/', $parameter, $typeName)) { |
Member
There was a problem hiding this comment.
I would not use $typeName to store the regex matches. Repurposing the same variable name for something else makes the code much harder to read.
Same is true for the output of $parameter->getType() btw
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No behavioral change, just a small refacto that I'm needing for two different PRs I'm working on - will make reviewing them easier also.
Best reviewed by ignoring whitespaces.