[Uid] Ensure UuidV1 is created in lowercase

smnandre · smnandre · commit b75d6a03359b · 2024-07-30T22:47:22.000+02:00
diff --git a/src/Symfony/Component/Uid/Tests/UuidTest.php b/src/Symfony/Component/Uid/Tests/UuidTest.php
@@ -95,6 +95,15 @@ public function testV1()
         $this->assertSame('3499710062d0', $uuid->getNode());
     }
 
+    public function testV1IsLowerCase()
+    {
+        $uuid = new UuidV1();
+        $this->assertSame(strtolower((string) $uuid), (string) $uuid);
+
+        $uuid = new UuidV1('D9E7A184-5D5B-11EA-A62A-3499710062D0');
+        $this->assertSame(strtolower((string) $uuid), (string) $uuid);
+    }
+
     public function testV3()
     {
         $uuid = Uuid::v3(new UuidV4(self::A_UUID_V4), 'the name');
diff --git a/src/Symfony/Component/Uid/UuidV1.php b/src/Symfony/Component/Uid/UuidV1.php
@@ -25,7 +25,7 @@ class UuidV1 extends Uuid implements TimeBasedUidInterface
     public function __construct(?string $uuid = null)
     {
         if (null === $uuid) {
-            $this->uid = uuid_create(static::TYPE);
+            $this->uid = strtolower(uuid_create(static::TYPE));
         } else {
             parent::__construct($uuid, true);
         }

Original file line number	Diff line number	Diff line change
`@@ -25,7 +25,7 @@ class UuidV1 extends Uuid implements TimeBasedUidInterface`
`25`	`25`	`public function __construct(?string $uuid = null)`
`26`	`26`	`{`
`27`	`27`	`if (null === $uuid) {`
`28`		`- $this->uid = uuid_create(static::TYPE);`
	`28`	`+ $this->uid = strtolower(uuid_create(static::TYPE));`
`29`	`29`	`} else {`
`30`	`30`	`parent::__construct($uuid, true);`
`31`	`31`	`}`