minor #47428 [Form][Validator] Fix checking result of DateTime::getLastErrors (nicolas-grekas)

nicolas-grekas · nicolas-grekas · commit cfc492e67068 · 2022-08-30T17:57:48.000+02:00
This PR was merged into the 4.4 branch. Discussion ---------- [Form][Validator] Fix checking result of DateTime::getLastErrors | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - Spotted by our CI on PHP 8.2 This returns an array on PHP < 8.2 and `false` on 8.2: ```php DateTime::createFromFormat('Y', '2022'); var_dump(DateTime::getLastErrors()); ``` /cc `@derickr` FYI as this might also be considered as a BC break on PHP 8.2 Commits ------- 39cd15b Fix checking result of DateTime::getLastErrors
diff --git a/src/Symfony/Component/Form/Extension/Core/DataTransformer/DateTimeToStringTransformer.php b/src/Symfony/Component/Form/Extension/Core/DataTransformer/DateTimeToStringTransformer.php
@@ -121,7 +121,7 @@ public function reverseTransform($value)
         $outputTz = new \DateTimeZone($this->outputTimezone);
         $dateTime = \DateTime::createFromFormat($this->parseFormat, $value, $outputTz);
 
-        $lastErrors = \DateTime::getLastErrors();
+        $lastErrors = \DateTime::getLastErrors() ?: ['error_count' => 0, 'warning_count' => 0];
 
         if (0 < $lastErrors['warning_count'] || 0 < $lastErrors['error_count']) {
             throw new TransformationFailedException(implode(', ', array_merge(array_values($lastErrors['warnings']), array_values($lastErrors['errors']))));
diff --git a/src/Symfony/Component/Validator/Constraints/DateTimeValidator.php b/src/Symfony/Component/Validator/Constraints/DateTimeValidator.php
@@ -48,7 +48,7 @@ public function validate($value, Constraint $constraint)
 
         \DateTime::createFromFormat($constraint->format, $value);
 
-        $errors = \DateTime::getLastErrors();
+        $errors = \DateTime::getLastErrors() ?: ['error_count' => 0, 'warnings' => []];
 
         if (0 < $errors['error_count']) {
             $this->context->buildViolation($constraint->message)
