[Form][Validator] Fix checking result of DateTime::getLastErrors #47428
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chalasr
approved these changes
Aug 30, 2022
f7da2e5 to
c2eb637
Compare
xabbuh
approved these changes
Aug 30, 2022
xabbuh
requested changes
Aug 30, 2022
|
Access to |
|
On 30 August 2022 11:25:46 BST, Nicolas Grekas ***@***.***> wrote:
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | yes
| New feature? | no
| Deprecations? | no
| Tickets | -
| License | MIT
| Doc PR | -
Spotted by our CI on PHP 8.2
This returns an array on PHP < 8.2 and `false` on 8.2:
```php
DateTime::createFromFormat('Y', '2022');
var_dump(DateTime::getLastErrors());
```
/cc @derickr FYI as this might also be considered as a BC break on PHP 8.2
You can view, comment on, or merge this pull request online at:
#47428
-- Commit Summary --
* Fix checking result of DateTime::getLastErrors
-- File Changes --
M src/Symfony/Component/Form/Extension/Core/DataTransformer/DateTimeToStringTransformer.php (2)
M src/Symfony/Component/Validator/Constraints/DateTimeValidator.php (2)
-- Patch Links --
https://github.com/symfony/symfony/pull/47428.patch
https://github.com/symfony/symfony/pull/47428.diff
This is a bug fix as the new 8.2 behaviour is how it has been documented for over a decade. I didn't merge it to 8.0 and 8.1 because it does change BC.
|
Well, I would say that code is a lot more likely to expect the behavior that exists since a decade than the documented code that was never implemented until now. |
derrabus
approved these changes
Aug 30, 2022
yup, fixed |
c2eb637 to
39cd15b
Compare
stof
approved these changes
Aug 30, 2022
xabbuh
approved these changes
Aug 30, 2022
|
I just stumbled upon this bug in my project, wrote the pr, unit test and was getting ready to submit and then checked my branch was up to date and it wasn't, so checked here and BANG 🎉 its already fixed 5 days ago... you guys are awesome! |
This was referenced Sep 5, 2022
fabpot
added a commit
to sensiolabs/SensioFrameworkExtraBundle
that referenced
this pull request
Sep 5, 2022
This PR was squashed before being merged into the 6.1.x-dev branch. Discussion ---------- PHP 8.2 Compatibility DateTime::getLastErrors DateTime::getLastErrors() is documented as returning `array|false` https://www.php.net/manual/en/datetime.getlasterrors.php As discussed here symfony/symfony#47428 (comment) `@derickr` quoted as saying "This is a bug fix as the new 8.2 behaviour is how it has been documented for over a decade." Commits ------- 00f08ea PHP 8.2 Compatibility DateTime::getLastErrors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spotted by our CI on PHP 8.2
This returns an array on PHP < 8.2 and
falseon 8.2:/cc @derickr FYI as this might also be considered as a BC break on PHP 8.2