allow button names to start with uppercase letter

xabbuh · xabbuh · commit d811b0e9b50b · 2019-11-19T08:55:12.000+01:00
diff --git a/UPGRADE-4.3.md b/UPGRADE-4.3.md
@@ -96,7 +96,7 @@ Form
 ----
 
  * Using the `format` option of `DateType` and `DateTimeType` when the `html5` option is enabled is deprecated.
- * Using names for buttons that do not start with a lowercase letter, a digit, or an underscore is deprecated and will lead to an
+ * Using names for buttons that do not start with a letter, a digit, or an underscore is deprecated and will lead to an
    exception in 5.0.
  * Using names for buttons that do not contain only letters, digits, underscores, hyphens, and colons is deprecated and
    will lead to an exception in 5.0.
diff --git a/UPGRADE-5.0.md b/UPGRADE-5.0.md
@@ -110,7 +110,7 @@ Form
 ----
 
  * Removed support for using the `format` option of `DateType` and `DateTimeType` when the `html5` option is enabled.
- * Using names for buttons that do not start with a lowercase letter, a digit, or an underscore leads to an exception.
+ * Using names for buttons that do not start with a letter, a digit, or an underscore leads to an exception.
  * Using names for buttons that do not contain only letters, digits, underscores, hyphens, and colons leads to an
    exception.
  * Using the `date_format`, `date_widget`, and `time_widget` options of the `DateTimeType` when the `widget` option is
diff --git a/src/Symfony/Component/Form/ButtonBuilder.php b/src/Symfony/Component/Form/ButtonBuilder.php
@@ -61,7 +61,7 @@ public function __construct(?string $name, array $options = [])
         $this->name = $name;
         $this->options = $options;
 
-        if (preg_match('/^([^a-z0-9_].*)?(.*[^a-zA-Z0-9_\-:].*)?$/D', $name, $matches)) {
+        if (preg_match('/^([^a-zA-Z0-9_].*)?(.*[^a-zA-Z0-9_\-:].*)?$/D', $name, $matches)) {
             if (isset($matches[1])) {
                 @trigger_error(sprintf('Using names for buttons that do not start with a lowercase letter, a digit, or an underscore is deprecated since Symfony 4.3 and will throw an exception in 5.0 ("%s" given).', $name), E_USER_DEPRECATED);
             }
diff --git a/src/Symfony/Component/Form/CHANGELOG.md b/src/Symfony/Component/Form/CHANGELOG.md
@@ -6,7 +6,7 @@ CHANGELOG
 
  * added a `symbol` option to the `PercentType` that allows to disable or customize the output of the percent character
  * Using the `format` option of `DateType` and `DateTimeType` when the `html5` option is enabled is deprecated.
- * Using names for buttons that do not start with a lowercase letter, a digit, or an underscore is deprecated and will lead to an
+ * Using names for buttons that do not start with a letter, a digit, or an underscore is deprecated and will lead to an
    exception in 5.0.
  * Using names for buttons that do not contain only letters, digits, underscores, hyphens, and colons is deprecated and
    will lead to an exception in 5.0.
diff --git a/src/Symfony/Component/Form/Tests/ButtonBuilderTest.php b/src/Symfony/Component/Form/Tests/ButtonBuilderTest.php
@@ -47,14 +47,6 @@ public function testNameContainingIllegalCharacters()
         $this->assertInstanceOf('\Symfony\Component\Form\ButtonBuilder', new ButtonBuilder('button[]'));
     }
 
-    /**
-     * @group legacy
-     */
-    public function testNameStartingWithIllegalCharacters()
-    {
-        $this->assertInstanceOf('\Symfony\Component\Form\ButtonBuilder', new ButtonBuilder('Button'));
-    }
-
     public function getInvalidNames()
     {
         return [

Original file line number	Diff line number	Diff line change
`@@ -61,7 +61,7 @@ public function __construct(?string $name, array $options = [])`
`61`	`61`	`$this->name = $name;`
`62`	`62`	`$this->options = $options;`
`63`	`63`
`64`		`- if (preg_match('/^([^a-z0-9_].)?(.[^a-zA-Z0-9_\-:].*)?$/D', $name, $matches)) {`
	`64`	`+ if (preg_match('/^([^a-zA-Z0-9_].)?(.[^a-zA-Z0-9_\-:].*)?$/D', $name, $matches)) {`
`65`	`65`	`if (isset($matches[1])) {`
`66`	`66`	`@trigger_error(sprintf('Using names for buttons that do not start with a lowercase letter, a digit, or an underscore is deprecated since Symfony 4.3 and will throw an exception in 5.0 ("%s" given).', $name), E_USER_DEPRECATED);`
`67`	`67`	`}`
Original file line number	Diff line number	Diff line change
`@@ -47,14 +47,6 @@ public function testNameContainingIllegalCharacters()`
`47`	`47`	`$this->assertInstanceOf('\Symfony\Component\Form\ButtonBuilder', new ButtonBuilder('button[]'));`
`48`	`48`	`}`
`49`	`49`
`50`		`- /**`
`51`		`- * @group legacy`
`52`		`- */`
`53`		`- public function testNameStartingWithIllegalCharacters()`
`54`		`- {`
`55`		`- $this->assertInstanceOf('\Symfony\Component\Form\ButtonBuilder', new ButtonBuilder('Button'));`
`56`		`- }`
`57`		`-`
`58`	`50`	`public function getInvalidNames()`
`59`	`51`	`{`
`60`	`52`	`return [`