bug #36517 [Notifier] Fix error handling for Free mobile (fabpot)

fabpot · fabpot · commit e36ea501a704 · 2020-04-21T16:39:06.000+02:00
This PR was merged into the 5.1-dev branch. Discussion ---------- [Notifier] Fix error handling for Free mobile | Q | A | ------------- | --- | Branch? | master | Bug fix? | yes | New feature? | no  | Deprecations? | no  | Tickets | n/a  | License | MIT | Doc PR | n/a Looks like the error handling code for Free mobile is a copy/paste from Twilio. /cc @noniagriconomie Commits ------- 6167ce4 [Notifier] Fix error handling for Free mobile
diff --git a/src/Symfony/Component/Notifier/Bridge/FreeMobile/FreeMobileTransport.php b/src/Symfony/Component/Notifier/Bridge/FreeMobile/FreeMobileTransport.php
@@ -66,9 +66,14 @@ protected function doSend(MessageInterface $message): void
         ]);
 
         if (200 !== $response->getStatusCode()) {
-            $error = $response->toArray(false);
+            $errors = [
+                400 => 'Missing required parameter or wrongly formatted message.',
+                402 => 'Too many messages have been sent too fast.',
+                403 => 'Service not enabled or wrong credentials.',
+                500 => 'Server error, please try again later.',
+            ];
 
-            throw new TransportException(sprintf('Unable to send the SMS: "%s" (see "%s").', $error['message'], $error['more_info']), $response);
+            throw new TransportException(sprintf('Unable to send the SMS: error %d: ', $response->getStatusCode()).($errors[$response->getStatusCode()] ?? ''), $response);
         }
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -66,9 +66,14 @@ protected function doSend(MessageInterface $message): void`
`66`	`66`	`]);`
`67`	`67`
`68`	`68`	`if (200 !== $response->getStatusCode()) {`
`69`		`- $error = $response->toArray(false);`
	`69`	`+ $errors = [`
	`70`	`+ 400 => 'Missing required parameter or wrongly formatted message.',`
	`71`	`+ 402 => 'Too many messages have been sent too fast.',`
	`72`	`+ 403 => 'Service not enabled or wrong credentials.',`
	`73`	`+ 500 => 'Server error, please try again later.',`
	`74`	`+ ];`
`70`	`75`
`71`		`- throw new TransportException(sprintf('Unable to send the SMS: "%s" (see "%s").', $error['message'], $error['more_info']), $response);`
	`76`	`+ throw new TransportException(sprintf('Unable to send the SMS: error %d: ', $response->getStatusCode()).($errors[$response->getStatusCode()] ?? ''), $response);`
`72`	`77`	`}`
`73`	`78`	`}`
`74`	`79`	`}`