review suggestions

Artem Stepin · Artem Stepin · commit e9daeba63240 · 2020-12-16T11:06:06.000+01:00
diff --git a/src/Symfony/Component/Ldap/Tests/Adapter/ExtLdap/EntryManagerTest.php b/src/Symfony/Component/Ldap/Tests/Adapter/ExtLdap/EntryManagerTest.php
@@ -47,7 +47,7 @@ public function testGetResources()
 
     /**
      * @see https://tools.ietf.org/html/rfc4514#section-3
-     * @dataProvider getDataProviderDns
+     * @dataProvider moveWithRFC4514DistinguishedNameProvider
      */
     public function testMoveWithRFC4514DistinguishedName(string $testDn, string $expectedRdn)
     {
@@ -64,7 +64,7 @@ public function testMoveWithRFC4514DistinguishedName(string $testDn, string $exp
         $this->assertSame($expectedRdn, $cn);
     }
 
-    public function getDataProviderDns(): array
+    public function moveWithRFC4514DistinguishedNameProvider(): array
     {
         return [
             ['CN=Simple,DC=example,DC=net', 'CN=Simple'],

Original file line number	Diff line number	Diff line change
`@@ -47,7 +47,7 @@ public function testGetResources()`
`47`	`47`
`48`	`48`	`/**`
`49`	`49`	`* @see https://tools.ietf.org/html/rfc4514#section-3`
`50`		`- * @dataProvider getDataProviderDns`
	`50`	`+ * @dataProvider moveWithRFC4514DistinguishedNameProvider`
`51`	`51`	`*/`
`52`	`52`	`public function testMoveWithRFC4514DistinguishedName(string $testDn, string $expectedRdn)`
`53`	`53`	`{`
`@@ -64,7 +64,7 @@ public function testMoveWithRFC4514DistinguishedName(string $testDn, string $exp`
`64`	`64`	`$this->assertSame($expectedRdn, $cn);`
`65`	`65`	`}`
`66`	`66`
`67`		`- public function getDataProviderDns(): array`
	`67`	`+ public function moveWithRFC4514DistinguishedNameProvider(): array`
`68`	`68`	`{`
`69`	`69`	`return [`
`70`	`70`	`['CN=Simple,DC=example,DC=net', 'CN=Simple'],`