Thanks to visit codestin.com
Credit goes to github.com

Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: symfony/symfony
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 6a9f47c
Choose a base ref
...
head repository: freimair/symfony
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 42a0884
Choose a head ref
  • 6 commits
  • 2 files changed
  • 1 contributor

Commits on Aug 12, 2022

  1. Configuration menu
    Copy the full SHA
    010af2a View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    50d6cd1 View commit details
    Browse the repository at this point in the history

Commits on Aug 23, 2022

  1. Set max to int since it cannot be null

    `max` value has been prepared to contain a `null` value, however,
    the constructor with its default value of `max = 0` prevents
    `$max` to ever be `null`.
    
    Hence, declare `$max` as `int` instead of `?int`.
    freimair committed Aug 23, 2022
    Configuration menu
    Copy the full SHA
    eac82fc View commit details
    Browse the repository at this point in the history
  2. Introduce isMaxKnown variable

    Up until now, it has been very hard to determin whether a progressbar
    has a known maximum value or not, because the property `max` is an
    integer. Up until now, `max == 0` has been treated like we do _not_
    know the `max` value. However, `max == 0` _is_ a valid `max` value
    when iterating over an empty but countable array for example.
    
    We cannot simply keep `max == null` if unknown, because that would break
    rendering mechanics and fixing those would require interface changes.
    
    Hence, enter `isMaxKnown` - a property which keeps track of whether the
    `max` value is known or not.
    freimair committed Aug 23, 2022
    Configuration menu
    Copy the full SHA
    9701863 View commit details
    Browse the repository at this point in the history
  3. Ui work

    freimair committed Aug 23, 2022
    Configuration menu
    Copy the full SHA
    d0cc3bd View commit details
    Browse the repository at this point in the history

Commits on Oct 23, 2023

  1. Configuration menu
    Copy the full SHA
    42a0884 View commit details
    Browse the repository at this point in the history
Loading