-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[Stopwatch] add retrieval of sections #10145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Will getter for private attribute |
@havvg Where are you trying to visualize the Stopwatch data? According to TimeDataCollector it's possible to fetch it using the Debug token (given we are in the profiler or using the debug mode). @fabpot Correct me if I'm wrong, but according to the |
@maxromanovsky I'm outside of the framework, just plain Stopwatch Component. I get an instance of the My intension of this issue was more like getting feedback on how to actually solve this issue. The Re-factoring this into a more open variant is simple (e.g. adding an ImmutableStopwatch, ..), but is it fine, too? |
@havvg Let's wait for the decision of Fabien or other guys from Core Team. |
I don't really remember why Section was made private back then. I think it makes sense to let anyone introspect/traverse the sections, so making everything "public" makes sense I think. |
This PR was squashed before being merged into the 2.3-dev branch (closes #10851). Discussion ---------- Added retrieval of sections | Q | A | ------------- | --- | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #10145 | License | MIT Commits ------- 7928767 Added retrieval of sections
I'm on to visualizing stopwatch data. However, I can't find any valid way to retrieve sections of a stopwatch.
There is
Stopwatch::getSectionEvents($id)
, only. This method however requires to know which sections are available. How to retrieve those sections without relying on internals of the component?The text was updated successfully, but these errors were encountered: