Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Hackday] [2.7] Add a deprecation note about ValidationVisitorInterface and ValidationVisitor #12675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
javiereguiluz opened this issue Nov 29, 2014 · 2 comments

Comments

@javiereguiluz
Copy link
Member

NOTE: This issue is part of the "SymfonyCon 2014 Madrid Hackday" effort to add logs for every 2.7 deprecated feature. This is needed before removing those features in 3.0 version. Please, add you name in a comment of this issue if you are going to work on this.

If you need it, this Gist explains how to generate the deprecation note:

https://gist.github.com/javiereguiluz/a5514ec6cde2a63be441


The interface ValidationVisitorInterface and its implementation
ValidationVisitor were removed. The implementation of the visitor pattern
was flawed. Fixing that implementation would have drastically slowed down
the validator execution, so the visitor was removed completely instead.

Along with the visitor, the method accept() was removed from
MetadataInterface.

@neoshadybeat
Copy link
Contributor

I'm working on It

@aferrandini
Copy link
Contributor

If you need it, this Gist explains how to generate an interface deprecation note:

https://gist.github.com/aferrandini/0cf9aaa9901742871492

neoshadybeat added a commit to neoshadybeat/symfony that referenced this issue Nov 29, 2014
neoshadybeat added a commit to neoshadybeat/symfony that referenced this issue Nov 29, 2014
neoshadybeat added a commit to neoshadybeat/symfony that referenced this issue Nov 29, 2014
neoshadybeat added a commit to neoshadybeat/symfony that referenced this issue Nov 29, 2014
fabpot added a commit that referenced this issue Nov 30, 2014
…ValidationVisito... (neoshadybeat)

This PR was merged into the 2.7 branch.

Discussion
----------

[Validator][Hackday] [2.7] Add a deprecation note about ValidationVisito...

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | yes
| Tests pass?   | yes
| Fixed tickets | #12755
| License       | MIT
| Doc PR        | none

Commits
-------

786e509 [Validator][Hackday] [2.7] Add a deprecation note about ValidationVisitorInterface and ValidationVisitor #12675
fabpot added a commit that referenced this issue Jan 5, 2015
This PR was merged into the 2.7 branch.

Discussion
----------

[2.7] adds deprecation notices.

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | yes
| Tests pass?   | yes
| Fixed tickets | #12608, #12672, #12675 #12684, #12686
| License       | MIT
| Doc PR        | ~

Commits
-------

f9fbb4f Fixes more deprecation notices as per @stof review.
fd47c07 Fixed some deprecations according to @stof feedbacks.
2a3e7d2 Normalizes deprecation notice messages.
738b9be [Validator] fixes UuidValidator deprecated class namespace.
e608ba6 [Form] adds more deprecation notices.
cd9617a [Validator] adds more deprecation notices.
a7f841e [Form] Adds a way to trigger deprecation notice on demand for VirtualFormAwareIterator class.
97efd2c Fixes more deprecation notices.
fd9c7bb Normalized @deprecated annotations.
39cfd47 Removed deprecation notices from test files.
2a9749d Fixes deprecation notices.
6f57b7b Reverted trigger_error() function calls on deprecated interfaces to prevent breaking third party projects implementing them.
86b9f6b Adds deprecation notices for structures to be removed in 3.0.
@fabpot fabpot closed this as completed Jan 5, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants