Towards PHP 7 compatibility #14086

stof · 2015-03-27T17:23:03Z

PHP 7 is meant to be released at the end of the year. At this time, our supported versions will be 2.3, 2.6 (security-only), 2.7 and 3.0. Each of these versions will need to be compatible with PHP 7.

Currently, Travis is running our testsuite against PHP 7 nightly, showing that this goal is not yet reached.

A bunch of tests are triggering fatal errors. We should debug the reason for that, to see whether it is a regression in PHP (which should be reported to them as soon as possible) or something related to one of the PHP 7 BC breaks, requiring to fix our code:

form tests: https://travis-ci.org/symfony/symfony/jobs/56106607#L355
security tests: https://travis-ci.org/symfony/symfony/jobs/56106607#L411
translation tests: https://travis-ci.org/symfony/symfony/jobs/56106607#L562 string cannot be used as class name (reserved because of scalar type hints)

Except these components where we cannot run tests because of these errors, the only remaining failures on PHP 7 for Symfony 2.3 (you can check Travis builds for other branches to see whether there are more in newer versions) are the parsing of hexadecimal numeric strings in XmlUtils and Yaml because PHP 7 does not cast them as int anymore. We will need to implement this conversion separately.
It would be great to start working on the PHP 7 compatibility soon (especially for the issue with class names being reserved because it might require deprecating a class name in favor of a new one, which should be done before the 2.7 release)

The text was updated successfully, but these errors were encountered:

Tobion · 2015-03-27T18:34:14Z

For Translation component: #14087

dosten · 2015-03-27T19:14:26Z

The Security test seems to be a phpunit issue

xabbuh · 2015-03-27T19:29:08Z

@dosten Did you see an open issue at the PhpUnit repo?

dosten · 2015-03-27T20:24:38Z

@xabbuh No, i see that the error come from here https://github.com/symfony/security-core/blob/master/Tests/Authentication/Token/RememberMeTokenTest.php#L55-L62.
Seems that PHPUnit is not catching the exceptions in PHP7.

Tobion · 2015-03-27T20:37:15Z

That test doesn't make sense. You don't test against phpunit exceptions and even testing fatal errors that are ensured by the language is even worse. Then we would have to add a lot of tests. I'll fix it.

Tobion · 2015-03-27T21:24:55Z

See #14088

This PR was merged into the 2.3 branch. Discussion ---------- remove useless tests that fail in php 7 | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #14086 for Security and Form component | License | MIT | Doc PR | - `@expectedException \PHPUnit_Framework_Error` doesn't catch php fatal errors for wrong types in php 7. But these test are also pretty useless anyway. Then we would have to add a lot of tests for all arguments that are typehinted. Let's just remove these tests. Commits ------- 59cab27 remove useless tests that fail in php 7

This PR was merged into the 2.3 branch. Discussion ---------- [Translator] fix test for php 7 compatibility | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #14086 for Translation component | License | MIT | Doc PR | - Commits ------- 02b829f [Translator] fix test for php 7 compatibility

stof · 2015-03-30T07:45:17Z

See #14107 for the remaining work

This PR was merged into the 2.3 branch. Discussion ---------- Add parsing of hexadecimal strings for PHP 7 | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #14086 | License | MIT | Doc PR | n/a PHP 7 does not handle the hexadecimal notation in is_numeric checks anymore, so the detection needs to be implemented explicitly. With this change, we should have a passing testsuite on PHP 7 Commits ------- e848040 Add parsing of hexadecimal strings for PHP 7

stof · 2015-04-02T13:51:46Z

Reopening because we are not there yet.

We have some classes using reserved keywords in the Validator component (the True and False constraints for instance).
The only way to fix this is to rename the constraint to a different name and deprecate the old name (providing it through a class_alias for PHP 5.x to avoid defining a class with the reserved named for PHP 7). So we must do it before the 2.7 release to have the new constraint names in the LTS version.

We also have some test failures in the Debug, Translation and VarDumper components

nicolas-grekas · 2015-04-03T17:39:01Z

See #14204 for VarDumper

For Debug (and maybe also VarDumper), we'll have to wait until the new exception mechanism is stabilized

stefanruijsenaars · 2015-05-06T21:37:01Z

I think #14228 is ready now, how are we doing otherwise with this issue?

stefanruijsenaars · 2015-05-07T11:07:37Z

Just crossposting @nicolas-grekas comments from #14228 which seems to help the tests a bit further along and exposes a fatal error for the Validator component. Possibly a PHP 7 bug or maybe it's something we can code around.

Anyone have a PHP 7 setup to debug this on?: https://travis-ci.org/symfony/symfony/jobs/61229099#L560

…straints as they are reserved words in PHP7 (stefan.r) This PR was merged into the 2.3 branch. Discussion ---------- Add PHP7 compatible versions for the Null/True/False constraints as they are reserved words in PHP7 | Q | A | ------------- | --- | Bug fix? | PHP7 compatibility | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | N/A | Fixed tickets | N/A - helps towards #14086 | License | MIT Null, True and False are reserved words in PHP7: https://wiki.php.net/rfc/reserve_more_types_in_php_7 Commits ------- 44edbdf Fixed compatibility with PHP7 and up by introducing new constraints (IsNull, IsTrue, IsFalse) and related validators (IsNullValidator, IsTrueValidator, IsFalseValidator)

…straints as they are reserved words in PHP7 (stefan.r) This PR was merged into the 2.3 branch. Discussion ---------- Add PHP7 compatible versions for the Null/True/False constraints as they are reserved words in PHP7 | Q | A | ------------- | --- | Bug fix? | PHP7 compatibility | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | N/A | Fixed tickets | N/A - helps towards symfony/symfony#14086 | License | MIT Null, True and False are reserved words in PHP7: https://wiki.php.net/rfc/reserve_more_types_in_php_7 Commits ------- 44edbdf Fixed compatibility with PHP7 and up by introducing new constraints (IsNull, IsTrue, IsFalse) and related validators (IsNullValidator, IsTrueValidator, IsFalseValidator)

stof · 2015-05-15T09:52:06Z

Remaining issues on PHP 7:

the fatal error in the Validator tests
the YAML component failures

bitraft · 2015-07-16T05:36:46Z

any update ?

fabpot · 2015-07-16T10:24:40Z

@changloong We've fixed a bunch of other errors, but not all of them. If you have some time, can you help us finish this one?

bitraft · 2015-07-16T16:11:58Z

Hi @fabpot

I think I can work on this and make some pull request when I pass my local test:)

GrahamCampbell · 2015-07-16T22:15:00Z

The debug component needs updating to correctly display throwables. This came up in laravel 5.2.

fabpot · 2015-07-16T22:15:46Z

@GrahamCampbell That's probably something for @nicolas-grekas :)

GrahamCampbell · 2015-07-16T22:16:48Z

Great. :)

nicolas-grekas · 2015-07-16T22:26:38Z

I'll fix that asap :-)

GrahamCampbell · 2015-07-16T22:28:55Z

Loosing the exception typehint from non-private methods on non-final classes is a bigish breaking change though. Does this mean many of the changes can only be made on symfony 3.0?

mickaelandrieu · 2015-07-23T14:51:47Z

@stof I met some issues with ParameterBag / ContainerBuilder too. I will try to make a relevant issue asap :/

@jpauli

…-grekas) This PR was merged into the 2.3 branch. Discussion ---------- [php7] Fix for substr() always returning a string | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #14086 | License | MIT | Doc PR | - This should be the last required fix for PHP7 support. The patch in the debug component is a workaround for a bug in PHP7 (http://3v4l.org/8rm9B) that is going to be fixed soon (@jpauli power). Commits ------- 77ee866 [php7] Fix for substr() always returning a string

…-grekas) This PR was merged into the 2.7 branch. Discussion ---------- [php7] Fix for substr() always returning a string | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #14086 | License | MIT | Doc PR | - The remaining failures will stop once https://bugs.php.net/bug.php?id=70159 is fixed ([patch pending](php/php-src@a28115c)). Commits ------- d6dfe98 [php7] Fix for substr() always returning a string

…ekas) This PR was merged into the 2.3 branch. Discussion ---------- [travis] Build phpunit with local components | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #14086 | License | MIT | Doc PR | - The tests for PHP7 currently fail because travis ships with a phar phpunit that embeds the yaml components. This one takes priority over the one in the repo. But it is outdated. The issue arose with PHP7 tests but could have happen with any build. Commits ------- ce2a371 [travis] Build phpunit with local components

anacicconi · 2016-11-16T16:49:11Z

Sorry if my question is not in the right place but this discussion made me realize that I cannot upgrade my project to PHP7 as I'm using Symfony 2.8. I just checked on Github and all 2.8 related tags have the old names for the constraints (True, False, Null...). I was surprised because I had read this post before checking the code:

http://symfony.com/blog/symfony-achieves-100-php7-compatibility

If that's the case, do I have to upgrade to Symfony 3 in order to upgrade to PHP7? As Symfony 3.1 is not a LTS I thought it wasn't a good idea to use it on production. Am I right? How are you guys doing to have both a LTS Symfony version and PHP7 on production? Thanks!

lyrixx · 2016-11-16T16:52:54Z

Symfony 2.8 (and even 2.7) are compatible with PHP7. as you can see on github, the class True is deprecated. So if you don't use it, everything will be fine. Instead you should use IsTrue

xabbuh · 2016-11-16T16:53:42Z

@anacicconi All releases before Symfony 3.0 ship with both the legacy and the Is-prefixed class names (see for example True and IsTrue).

anacicconi · 2016-11-16T16:56:18Z

Oh, ok! I didn't understand that. So I can keep 2.8. Just out of curiosity, is it recommended to use Symfony3.1 on production?

stof · 2016-11-16T17:14:03Z

sure

lyrixx · 2016-11-16T17:14:16Z

@anacicconi sure. we are using it ;)

anacicconi · 2016-11-16T17:18:28Z

Ok, thanks ;)

Tobion mentioned this issue Mar 27, 2015

[Translator] fix test for php 7 compatibility #14087

Merged

Tobion mentioned this issue Mar 27, 2015

remove useless tests that fail in php 7 #14088

Merged

stof mentioned this issue Mar 30, 2015

Add parsing of hexadecimal strings for PHP 7 #14107

Merged

fabpot closed this as completed Mar 30, 2015

stof reopened this Apr 2, 2015

xabbuh mentioned this issue Apr 3, 2015

let Travis builds fail when PHP 7 jobs fail #14115

Merged

stefanruijsenaars mentioned this issue Apr 5, 2015

Add PHP7 compatible versions for the Null/True/False constraints as they are reserved words in PHP7 #14228

Merged

stof mentioned this issue Apr 13, 2015

[Valdiator] PHP Fatal error: Cannot use 'True' as class name as it is reserved #14336

Closed

GrahamCampbell mentioned this issue Jul 16, 2015

[L5.2][php7] Error with exeption laravel/framework#9650

Closed

nicolas-grekas mentioned this issue Jul 28, 2015

[php7] Fix for substr() always returning a string #15386

Merged

fabpot closed this as completed Jul 28, 2015

nicolas-grekas mentioned this issue Jul 28, 2015

[php7] Fix for substr() always returning a string #15390

Merged

nicolas-grekas mentioned this issue Aug 5, 2015

[travis] Build phpunit with local components #15457

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Towards PHP 7 compatibility #14086

Towards PHP 7 compatibility #14086

stof commented Mar 27, 2015

Tobion commented Mar 27, 2015

dosten commented Mar 27, 2015

xabbuh commented Mar 27, 2015

dosten commented Mar 27, 2015

Tobion commented Mar 27, 2015

Tobion commented Mar 27, 2015

stof commented Mar 30, 2015

stof commented Apr 2, 2015

nicolas-grekas commented Apr 3, 2015

stefanruijsenaars commented May 6, 2015

stefanruijsenaars commented May 7, 2015

stof commented May 15, 2015

bitraft commented Jul 16, 2015

fabpot commented Jul 16, 2015

bitraft commented Jul 16, 2015

GrahamCampbell commented Jul 16, 2015

fabpot commented Jul 16, 2015

GrahamCampbell commented Jul 16, 2015

nicolas-grekas commented Jul 16, 2015 via email

GrahamCampbell commented Jul 16, 2015

mickaelandrieu commented Jul 23, 2015

anacicconi commented Nov 16, 2016 •

edited

Loading

lyrixx commented Nov 16, 2016

xabbuh commented Nov 16, 2016

anacicconi commented Nov 16, 2016

stof commented Nov 16, 2016

lyrixx commented Nov 16, 2016

anacicconi commented Nov 16, 2016

Towards PHP 7 compatibility #14086

Towards PHP 7 compatibility #14086

Comments

stof commented Mar 27, 2015

Tobion commented Mar 27, 2015

dosten commented Mar 27, 2015

xabbuh commented Mar 27, 2015

dosten commented Mar 27, 2015

Tobion commented Mar 27, 2015

Tobion commented Mar 27, 2015

stof commented Mar 30, 2015

stof commented Apr 2, 2015

nicolas-grekas commented Apr 3, 2015

stefanruijsenaars commented May 6, 2015

stefanruijsenaars commented May 7, 2015

stof commented May 15, 2015

bitraft commented Jul 16, 2015

fabpot commented Jul 16, 2015

bitraft commented Jul 16, 2015

GrahamCampbell commented Jul 16, 2015

fabpot commented Jul 16, 2015

GrahamCampbell commented Jul 16, 2015

nicolas-grekas commented Jul 16, 2015 via email

GrahamCampbell commented Jul 16, 2015

mickaelandrieu commented Jul 23, 2015

anacicconi commented Nov 16, 2016 • edited Loading

lyrixx commented Nov 16, 2016

xabbuh commented Nov 16, 2016

anacicconi commented Nov 16, 2016

stof commented Nov 16, 2016

lyrixx commented Nov 16, 2016

anacicconi commented Nov 16, 2016

anacicconi commented Nov 16, 2016 •

edited

Loading