Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix choice lists refacto #14193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
nicolas-grekas opened this issue Apr 3, 2015 · 9 comments
Closed

Fix choice lists refacto #14193

nicolas-grekas opened this issue Apr 3, 2015 · 9 comments
Labels
BC Break Form

Comments

@nicolas-grekas
Copy link
Member

Reminder issue for taking care of comments on #14050 (ping @webmozart )
@xabbuh
Copy link
Member

xabbuh commented Apr 3, 2015

see also #14165

@xabbuh xabbuh added the Form label Apr 3, 2015
@fabpot
Copy link
Member

fabpot commented Apr 3, 2015

@webmozart Can you take care of this one ASAP? It means that tests are broken for now and that is going to block the first beta of Symfony 2.7.

@webmozart
Copy link
Contributor

See #14200 for the CHANGELOG/UPGRADE update.

@webmozart
Copy link
Contributor

See #14201 for the trigger_error() fix.

@webmozart
Copy link
Contributor

See #14202 for a minor code fix.

@webmozart
Copy link
Contributor

As pointed out by @stof, the deprecation policy of the new "choices_as_values" option is problematic. This needs to be fixed once #14200 is merged.

@webmozart
Copy link
Contributor

The constructor arguments of the new ChoiceView class are unnecessarily reversed compared to the old one, which makes migration more difficult. There was some reason behind this change, but I can't recall, so the argument order should be reversed again to match the old class. This needs to be done once #14200 is merged.

@xabbuh
Copy link
Member

xabbuh commented May 31, 2015

Is there anything else we can do here? Given that we have a stable 2.7 release now, we should not swap constructor arguments in ChoiceView again, but keep the inconsistency now.

@nicolas-grekas nicolas-grekas mentioned this issue Jun 5, 2015
Merged
@nicolas-grekas
Copy link
Member Author

@stof or @webmozart could you please see if you can do something about the deprecation policy (see above now that #14200 is merged?

fabpot added a commit that referenced this issue Jun 10, 2015
@fabpot
bug #14887 [Form] Swap new ChoiceView constructor arguments to ease m…
eb366b9 
…igrating from the deprecated one (nicolas-grekas)

This PR was merged into the 2.7 branch.

Discussion
----------

[Form] Swap new ChoiceView constructor arguments to ease migrating from the deprecated one

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #14193
| License       | MIT
| Doc PR        | -

Commits
-------

909d2b9 [Form] Swap new ChoiceView constructor arguments to ease migrating from the deprecated one
@fabpot fabpot closed this as completed Jun 10, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
BC Break Form
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@fabpot @webmozart @nicolas-grekas @xabbuh