[2.7][Asset] Empty version strategy for package #14832

badlamer · 2015-06-02T11:16:16Z

Hello! In ~2.6 version was EmptyVersionStrategy for images package. In 2.7 replaced default version from framework.assets

framework:
    assets:
        version: %assets_version%
        base_urls: %cdn_urls%
        packages:
            images:
                version:              ~
                version_format:       null
                base_urls: %cdn_urls%

From app/cache/prod/appProdProjectContainer.php

    protected function getAssets_VersionDefaultService()
    {
        return $this->services['assets._version__default'] = new \Symfony\Component\Asset\VersionStrategy\StaticVersionStrategy('test', '%s?%s');
    }
    protected function getAssets_ContextService()
    {
        return $this->services['assets.context'] = new \Symfony\Component\Asset\Context\RequestStackContext($this->get('request_stack'));
    }
    protected function getAssets_PackagesService()
    {
        $a = $this->get('assets._version__default');
        $b = $this->get('assets.context');
        return $this->services['assets.packages'] = new \Symfony\Component\Asset\Packages(new \Symfony\Component\Asset\UrlPackage(array(0 => 'http://s1.cdn.ru', 1 => 'http://s2.cdn.ru'), $a, $b), array('images' => new \Symfony\Component\Asset\UrlPackage(array(0 => 'http://s1.cdn.ru', 1 => 'http://s2.cdn.ru'), $a, $b)));
    }

XWB · 2015-06-19T12:40:53Z

I'm having the same issue.

Prior to Symfony 2.7, the above configuration would result into:

{{ asset('test.png', 'images') }} => http://localhost.com/test.png]

Since Symfony 2.7 the query parameter is always appended, even if the value is empty:

{{ asset('test.png', 'images') }} => http://localhost.com/test.png?v=

Ping @fabpot @stof

stof · 2015-06-19T12:47:43Z

@XWB are you using null or an empty string as asset version ?

XWB · 2015-06-19T12:51:22Z

@stof I'm using the following config:

framework:
    assets:
        assets_version: %app_version%
        assets_version_format: "%%s?v=%%s"
        packages:
            images:
                version: ~
                version_format: ~

stof · 2015-06-19T12:58:31Z

and what is the value of the app_version parameter ?

XWB · 2015-06-19T13:02:01Z

A string:

class MyBundle extends Bundle
{
    public function build(ContainerBuilder $container)
    {
        parent::build($container);

        $container->setParameter('app_version', '2.3.4');
    }
}

XWB · 2015-06-25T11:34:12Z

@stof @fabpot Any idea?

dosten · 2015-06-25T13:06:07Z

Can you replicate it in a fresh Symfony install?

XWB · 2015-06-25T13:56:16Z

@dosten Yes I can.

stof · 2015-06-25T14:01:47Z

@XWB a comment from you which has been removed said it was related to the casting in f74a1f2#diff-5e7347edce37c5886ec67b7ba02f3a9cR81 Does it actually work if you removing the string casting there ?

XWB · 2015-06-25T14:05:36Z

@stof I tried, removing the string cast will just set the package version to the default version. So that does not work either.

XWB · 2015-06-25T14:13:19Z

I uploaded a fresh Symfony install:

https://github.com/XWB/asset

Checkout
Composer install
Navigate to /web/app/example

Modified files:

https://github.com/XWB/asset/blob/master/app/Resources/views/default/index.html.twig#L6
https://github.com/XWB/asset/blob/master/app/config/config.yml#L24:L29

XWB · 2015-06-26T12:40:25Z

Found it:

f74a1f2#diff-0e793081ceb720201745c982a568903fR619

Changing null === $version back to !$version makes it working again.

xabbuh · 2015-10-07T14:12:13Z

@badlamer I think we should not close here. The issue is still present and I still want to find some time to fix it. #15108 was not closed because this issue is invalid, but just because the proposed fix was not the right one.

ewgRa · 2015-11-09T22:40:23Z

PR for this issue - #16509

ewgRa · 2015-11-11T10:53:18Z

Also #16522 kind of PR for this issue, can help also, but in another way.

…ages (ewgRa) This PR was merged into the 2.7 branch. Discussion ---------- [2.7][Asset] Ability to set empty version strategy in packages | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no, but not sure, as for me test was wrong | Deprecations? | no | Tests pass? | yes | Fixed tickets | #14832 | License | MIT | Doc PR | Comment about '' thing. As you can see in xml test - we can't for attribute set null value. And for xml version '' empty string considered as null value, that affect all others formats and test is changed. Commits ------- 646fc9c Ability to set empty version strategy in packages

This PR was merged into the 2.7 branch. Discussion ---------- [2.7][Asset] Add defaultNull to version configuration | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #14832, #16511 | License | MIT | Doc PR | In #16511 PR was omitted defaultNull version for one case. Commits ------- 65adb72 add defaultNull to version

This PR was squashed before being merged into the 3.1-dev branch (closes #17532). Discussion ---------- [Asset] Version as service | Q | A | ------------- | --- | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | While I working on #14832 I realize that all this problems and hidden magic can be avoided, if we will have ability to set asset version strategy as service. This PR implementation of this idea. Now it is possible to do something like this: ```yaml framework: assets: version_strategy: assets.custom_version_strategy base_urls: http://cdn.example.com packages: foo: base_urls: ["https://example.com"] version_strategy: assets.custom_version_strategy ``` There is can be some conflicts with #16511 when it will be in master Commits ------- 52d116b [Asset] Version as service

badlamer changed the title ~~[2.7][Asset] CDN & Empty version strategy for package~~ [2.7][Asset] Empty version strategy for package Jun 2, 2015

xabbuh added the Asset label Jun 2, 2015

XWB mentioned this issue Jun 26, 2015

[Feedback required] Fixed asset version strategy #15108

Closed

xabbuh added the Bug label Jul 2, 2015

badlamer closed this as completed Oct 7, 2015

xabbuh reopened this Oct 7, 2015

xabbuh mentioned this issue Oct 19, 2015

asset component does not seem to work with imagine_filter #16279

Closed

ewgRa mentioned this issue Nov 9, 2015

[2.7][Asset] Ability to set empty version strategy in packages #16509

Closed

This was referenced Nov 10, 2015

[2.7][Asset] Ability to set empty version strategy in packages #16511

Merged

[Asset] ability to set assets_version_strategy as service #16522

Closed

fabpot closed this as completed Jan 24, 2016

ewgRa mentioned this issue Jan 25, 2016

[2.7][Asset] Add defaultNull to version configuration #17514

Merged

ewgRa mentioned this issue Jan 25, 2016

[Asset] Version as service #17532

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[2.7][Asset] Empty version strategy for package #14832

[2.7][Asset] Empty version strategy for package #14832

badlamer commented Jun 2, 2015

XWB commented Jun 19, 2015

stof commented Jun 19, 2015

XWB commented Jun 19, 2015

stof commented Jun 19, 2015

XWB commented Jun 19, 2015

XWB commented Jun 25, 2015

dosten commented Jun 25, 2015

XWB commented Jun 25, 2015

stof commented Jun 25, 2015

XWB commented Jun 25, 2015

XWB commented Jun 25, 2015

XWB commented Jun 26, 2015

xabbuh commented Oct 7, 2015

ewgRa commented Nov 9, 2015

ewgRa commented Nov 11, 2015

[2.7][Asset] Empty version strategy for package #14832

[2.7][Asset] Empty version strategy for package #14832

Comments

badlamer commented Jun 2, 2015

XWB commented Jun 19, 2015

stof commented Jun 19, 2015

XWB commented Jun 19, 2015

stof commented Jun 19, 2015

XWB commented Jun 19, 2015

XWB commented Jun 25, 2015

dosten commented Jun 25, 2015

XWB commented Jun 25, 2015

stof commented Jun 25, 2015

XWB commented Jun 25, 2015

XWB commented Jun 25, 2015

XWB commented Jun 26, 2015

xabbuh commented Oct 7, 2015

ewgRa commented Nov 9, 2015

ewgRa commented Nov 11, 2015