[Finder] Exclude files based on path before applying the sorting #15803
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sorting can be slow, so it is best to applied it after all filtering rules are applied instead of using a bigger list and filtering again after that.
|
👍 |
|
Thank you @stof. |
fabpot
added a commit
that referenced
this pull request
Sep 15, 2015
…orting (stof) This PR was merged into the 2.3 branch. Discussion ---------- [Finder] Exclude files based on path before applying the sorting | Q | A | ------------- | --- | Bug fix? | yes (perf) | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | n/a | License | MIT | Doc PR | n/a Sorting can be slow, so it is best to applied it after all filtering rules are applied instead of using a bigger list and filtering again after that. This impacts only people using both the sorting and the name filtering (with ``->names()`` or ``notNames()``) Commits ------- e5bf0ab Exclude files based on path before applying the sorting
|
We may even need to think about the order of the different filtering to put the faster filters first (so that slower filters only run for files not excluded already by faster filters). the current order of filters is quite random AFAICT (it depends mostly of when it was implemented) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorting can be slow, so it is best to applied it after all filtering rules are applied instead of using a bigger list and filtering again after that.
This impacts only people using both the sorting and the name filtering (with
->names()ornotNames())