Fix for broken paths introduced after Symfony upgraded to 2.7.5. #2478
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me. |
|
I didn't understand where actually this additional |
|
The additional "/" seems to be added by Syfmony, I've also seen this in earlier versions of Syfmony, but never caused a problem to me. |
|
Ok, @raistlin then we are merging it. Thanks |
DavertMik
added a commit
that referenced
this pull request
Oct 24, 2015
Fix for broken paths introduced after Symfony upgraded to 2.7.5.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We upgraded our symfony package to 2.7.5, only to find out that our codeception is broken.
After a whole day of debugging it turns out the issue was related to the recent modifications made to the Finder component for Symfony (#15826, #15802, #15803).
In the path to the test in the suite (in our case, we have a test for each bundle), an additional
/is added between the test and the suite, thus causing an issue in GroupLoader. i.e.:Line 109 of file Lib/GroupManager:
We were getting the following scenario:
$filename: /path/to/suite//path/to/test
$testPattern: /path/to/suite/path/to/test
And, the if condition was failing in all cases, which meant that none of our groups was working.
The provided fix will fix the path in case it's broken but will leave it unchanged in case it's fine.