-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
FrameworkBundle translator tests are failing for deps=high #15935
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
The entire test in question has been removed in 2.8. Honestly, I did not see what it was trying to test for (that has not been covered elsewhere). If you want to keep it, the problem is that at the end of the test, // refresh cache when resources is changed in debug mode.
$translator = $this->getTranslator($loader, array('cache_dir' => $this->tmpDir, 'debug' => true), 'yml');
$translator->setLocale('fr'); After the cache has been warmed (in the same test, above), this now switches |
@mpdude I think it shouldn't considered fresh because the resource used has been removed in the end of the test |
You mean the Then, you're loading a different set of resources so you need to use a different cache file. But that would also be pointless, because you'd warm the cache for a cache location A, assert that it works and then create a Translator with a different cache location B and make sure that there is no cached data there. IMO that does not add value. |
This PR was merged into the 2.7 branch. Discussion ---------- Remove failing test to fix #15935 | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #15935 | License | MIT | Doc PR | Test has been removed on 2.8 already in https://github.com/symfony/symfony/pull/15738/files#diff-990df0e8238847f8ae54e8227f295c22L107 Commits ------- 5392a0c Remove failing test
See https://travis-ci.org/symfony/symfony/jobs/82334660#L2124
this should be considered a critical issue. We need to bring our testsuite back to green to be meaningful (2.7.5 and 2.3.3 were released with red builds btw)
/cc @aitboudad
The text was updated successfully, but these errors were encountered: