[Console] Unexpected unsupported command option shortcut #18856
Labels
Comments
|
It is used from the FrameworkBundle for the shell Option https://github.com/symfony/symfony/blob/2.8/src/Symfony/Bundle/FrameworkBundle/Console/Application.php#L44 The Option is removed in 3.0 |
|
Ok, I see the point, the error is just raised when calling the command due to the duplicate alias of the Option. The error message is indeed misleading. |
|
I traced the issue down and just submitted a fix. #18864 |
|
Wonderful! Thanks for the fix |
fabpot
added a commit
that referenced
this issue
May 26, 2016
…uplicate option shortcut (peterrehm) This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes #18864). Discussion ---------- [Console][DX] Fixed ambiguous error message when using a duplicate option shortcut | Q | A | ------------- | --- | Branch? | 2.3 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #18856 | License | MIT | Doc PR | - I assume this should be merged into 2.3 as per @stof's comment. There is a race condition when you run a command which has a duplicate option shortcut. Simply changing the order so that Options are merged before the Arguments solves that race condition. ````php $this->setName('my:super:command') ->setAliases(['my:super:commandalias']) ->setDescription('Performs some irrelevant work.') ->addOption('survey', 'e', InputOption::VALUE_REQUIRED, 'My option with a shortcut.') ```` Gives the error message: ``` [Symfony\Component\Console\Exception\LogicException] An argument with name "command" already exists. ``` This happens as the first time the definition is merged happens here: https://github.com/symfony/symfony/blob/master/src/Symfony/Component/Console/Application.php#L820 As this throws an error here: https://github.com/symfony/symfony/blob/master/src/Symfony/Component/Console/Command/Command.php#L309 The commans are merged but not the options. Merging it then again when the command is run https://github.com/symfony/symfony/blob/master/src/Symfony/Component/Console/Command/Command.php#L217 throws an error due to the duplicate argument as the arguments already have been merged. This time the error message is not surpressed and will confuse the user. Changing the order should fix the issue for duplicate arguments as well as for duplicate options. Commits ------- 7cb7655 [Console][DX] Fixed ambiguous error message when using a duplicate option shortcut
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Hi,
I am using Symfony 2.8.6, and after creating a new Command, I stumbled upon an unexpected error:
After trying a lot of different solutions, I found out that the error had to do with the option shortcut I used:
After changing the alias (or setting it to null), the error just stopped popping out.
Is there any obvious reason I am missing here, or is this a bug?
Because to my knowledge "s" is not used anywhere else.
Furthermore, the error is awkwardly cryptic and gave me a hard time debugging this.
Regards,
Nicolas
The text was updated successfully, but these errors were encountered: