You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Following code review changes on #20199 (review) I reverted the mergeEnvPlaceholders. However I think I probably shouldn't have changed it as it seems to be broken now. array_merge_recursive will create this structure when the placeholder is initialized inside EnvPlaceholderParameterBag::get()
Which causes an error inside ContainerBuilder::resolveEnvPlaceholders as the placeholder is an array instead of a string.
ContextErrorException in ContainerBuilder.php line 1045: Warning: stripos(): needle is not a string or an integer
I don't think this can be fixed inside the envPlaceholders assignment because it's an issue related to the merging of two parameter bags, not the assignment of them. I would suggest using the original fix I proposed inside mergeEnvPlaceholders
The text was updated successfully, but these errors were encountered:
…adoo)
This PR was squashed before being merged into the 3.2-dev branch (closes#20214).
Discussion
----------
Fix/broken merging of parameter bag env placeholders
| Q | A
| ------------- | ---
| Branch? | "master"
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #20213
| License | MIT
| Doc PR | reference to the documentation PR, if any
In PR #20199 I made changes after review that broke the use of env variables, sorry about that - should have checked it a bit more before making the changes.
@nicolas-grekas, I know you're very busy with all that merging, but if you could take a look at this it would be great since you know most about it.
Commits
-------
b53e0de Fix/broken merging of parameter bag env placeholders
Following code review changes on #20199 (review) I reverted the
mergeEnvPlaceholders
. However I think I probably shouldn't have changed it as it seems to be broken now.array_merge_recursive
will create this structure when the placeholder is initialized insideEnvPlaceholderParameterBag::get()
And then once
mergeEnvPlaceholders
is called it results inWhich causes an error inside
ContainerBuilder::resolveEnvPlaceholders
as the placeholder is an array instead of a string.I don't think this can be fixed inside the envPlaceholders assignment because it's an issue related to the merging of two parameter bags, not the assignment of them. I would suggest using the original fix I proposed inside
mergeEnvPlaceholders
The text was updated successfully, but these errors were encountered: