Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Serializer] Can't use config files without bundle #21187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
chalasr opened this issue Jan 6, 2017 · 8 comments
Closed

[Serializer] Can't use config files without bundle #21187

chalasr opened this issue Jan 6, 2017 · 8 comments
Labels
Feature FrameworkBundle Serializer
Milestone
3.4

Comments

@chalasr
Copy link
Member

chalasr commented Jan 6, 2017 •
edited
Loading

Q A
Bug report? no
Feature request? yes
BC Break report? no
RFC? yes
Symfony version 3.3

Similar to #15655 for the serializer.
Actually, the serializer configuration files must reside in a bundle to be detected e.g. AppBundle/Resources/config/serialization.
On the other hand, translations files are loaded from bundles and from the global app/Resources/translations directory. For doctrine, the path of mapping files can be configured.

Shouldn't we try to detect those configuration files in %kernel.root_dir%/Resources/config/serialization as well?
@chalasr chalasr changed the title [Validator][Serializer] Can't use config files are unusable without bundle [Validator][Serializer] Can't use config files without bundle Jan 6, 2017
@ogizanagi
Copy link
Contributor

There is a pending PR regarding the validator: #19086 :)

@xabbuh xabbuh added this to the 3.x milestone Jan 7, 2017
@chalasr chalasr changed the title [Validator][Serializer] Can't use config files without bundle [Serializer] Can't use config files without bundle Jan 7, 2017
@chalasr
Copy link
Member Author

chalasr commented Jan 7, 2017

@ogizanagi I totally missed them, thanks.
Updated this to talk about the serializer only

@dunglas
Copy link
Member

dunglas commented Jan 7, 2017 •
edited
Loading

I agree it must be done for 3.3 as bundle-less apps will become first-class citizens. I can work on this.

@fabpot
Copy link
Member

fabpot commented Jan 7, 2017 via email

@chalasr
Copy link
Member Author

chalasr commented Jan 8, 2017

I can work on this.

Thanks. Note that #19086 does it for the validator by adding a config option instead of only detecting some given places in app/, I think it makes sense as it's consistent with the doctrine configuration.

@xabbuh xabbuh removed the Validator label Jan 8, 2017
@dunglas
Copy link
Member

dunglas commented Jan 12, 2017

I'll wait the merge of this one because most code can be factorized.

@chalasr
Copy link
Member Author

chalasr commented Jan 23, 2017

#19086 has been merged now

@chalasr chalasr mentioned this issue Mar 8, 2017
Merged
@chalasr
Copy link
Member Author

chalasr commented Mar 8, 2017

see #21924

fabpot added a commit that referenced this issue Mar 22, 2017
@fabpot
feature #21924 [FrameworkBundle] Allow to configure Serializer mappin…
3023e4b 
…g paths (chalasr)

This PR was merged into the 3.3-dev branch.

Discussion
----------

[FrameworkBundle] Allow to configure Serializer mapping paths

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #21187
| License       | MIT
| Doc PR        | todo

Follows #19086 for the Serializer

Commits
-------

5446903 [FrameworkBundle] Allow configuring serializer mapping paths
@fabpot fabpot closed this as completed Mar 22, 2017
@yceruto yceruto mentioned this issue Nov 6, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature FrameworkBundle Serializer
Projects
None yet
Milestone
3.4
Development

No branches or pull requests
5 participants
@fabpot @dunglas @xabbuh @ogizanagi @chalasr