[SecurityBundle] something is broken after recent commits #21809

antanas-arvasevicius · 2017-03-01T10:03:15Z

Q	A
Bug report?	yes
Feature request?	no
BC Break report?	no
RFC?	no
Symfony version	3.3.0-dev

Today we've got build error in our system:
Restored to last worked version on 'd69bb304001e57e00678b86e8e499067889db538'
Hope this info will help to spot a problem.

[04:39:32][Ant output]      [exec]      [exec] > Sensio\Bundle\DistributionBundle\Composer\ScriptHandler::clearCache
[04:39:32][Ant output]      [exec]      [exec] 
[04:39:32][Ant output]      [exec]      [exec] 
[04:39:32][Ant output]      [exec]      [exec]   [Symfony\Component\DependencyInjection\Exception\ServiceNotFoundException]
[04:39:32][Ant output]      [exec]      [exec]   The service "security.authentication.provider.simple_form.default" has a de
[04:39:32][Ant output]      [exec]      [exec]   pendency on a non-existent service "security.user.provider.concrete.carrier
[04:39:32][Ant output]      [exec]      [exec]   User".

Our security.yml:

security:
    providers:
        carrierUser:
            entity:
                class: System\Entity\CarrierUser
                property: email

    erase_credentials: false
    firewalls:
        dev:
            pattern: ^/(_(profiler|wdt)|css|images|js)/
            security: false

        default:
            anonymous: ~
            provider: carrierUser
            simple-form:
                check_path: /login_check
                require_previous_session: false
                authenticator: tms.security.authentication.provider
                failure_handler: auth.failure_handler
                failure_forward: true
                failure_path: false

    encoders:
        System\Entity\CarrierUser: bcrypt

The text was updated successfully, but these errors were encountered:

antanas-arvasevicius · 2017-03-01T10:10:50Z

Little findings: on working version there line in container build logs:
Symfony\Component\DependencyInjection\Compiler\InlineServiceDefinitionsPass: Inlined service "security.user.provider.concrete.carrieruser" to "security.firewall.map.context.default".

but in not working version there is line

``Symfony\Component\DependencyInjection\Compiler\InlineServiceDefinitionsPass: Inlined service "security.user.provider.concrete.carrierUser" to "security.firewall.map.context.default".```

Previous version automatically lowercased every provider name, but new version looks like not converting to lower cases. Maybe this is a case.

xabbuh · 2017-03-01T10:13:25Z

Which commit exactly did you use when experiencing this issue?

antanas-arvasevicius · 2017-03-01T10:18:21Z

today latest i think, just checked out from teamcity work dir:
here is: 28a00da

antanas-arvasevicius · 2017-03-01T10:18:55Z

But I don't know exactly which commit fails.

xabbuh · 2017-03-01T10:36:55Z

Can you check if the issue still persists when you only use lowercase letters for the user provider name?

mvrhov · 2017-03-01T12:04:24Z

If only the case sensitivity is the problem AFAIR this was done on purpose. And it should be in Changelog/Upgrade document.

antanas-arvasevicius · 2017-03-01T12:06:50Z

Yes, works then lowercasered. If it's by purpose then should throw exception about saying what is wrong exactly during configuration validation I think.
I'll probably tracked which commit broken this and will write details soon

…ntains upper cases then container didn't compile

antanas-arvasevicius · 2017-03-01T12:25:01Z

found a problem, it was during inconsistent getUserProviderId() usage, sometimes it was called like:
getUserProviderId(strtolower($name)); sometimes like getUserProviderId($name);

Fixed by putting strtolower() inside getUserProviderId

fbd9f88#diff-2be909961a57bf75fbb600c1f5fc46e3R320

xabbuh · 2017-03-01T12:51:19Z

@antanas-arvasevicius That commit was reverted later on. That's why I wonder if you still experience the issue when using the latest master branch.

xabbuh · 2017-03-01T12:54:01Z

Never mind, I see that f6637dd wasn't merged up to master yet.

…ntains upper cases then container didn't compile

… (xabbuh) This PR was merged into the 3.3-dev branch. Discussion ---------- Revert "[SecurityBundle] only pass relevant user provider" | Q | A | ------------- | --- | Branch? | master | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #21809, #21810 | License | MIT | Doc PR | This reverts commit d97e07f (applies #21798 on `master`). There is no merge commit that could be reverted. Commits ------- 5b016ce Revert "[SecurityBundle] only pass relevant user provider"

…upper cases then container didn't compile

…e contains upper cases then container didn't compile (Antanas Arvasevicius) This PR was submitted for the master branch but it was merged into the 2.7 branch instead (closes #21810). Discussion ---------- #21809 [SecurityBundle] bugfix: if security provider's name contains upper cases then container didn't compile | Q | A | ------------- | --- | Branch? | master | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? no | Tests pass? | yes | Fixed tickets | #21809 | License | MIT then security.yml providers was with upper case, on container compile error was thrown: ```` [04:39:32][Ant output] [exec] [exec] > Sensio\Bundle\DistributionBundle\Composer\ScriptHandler::clearCache [04:39:32][Ant output] [exec] [exec] [04:39:32][Ant output] [exec] [exec] [04:39:32][Ant output] [exec] [exec] [Symfony\Component\DependencyInjection\Exception\ServiceNotFoundException] [04:39:32][Ant output] [exec] [exec] The service "security.authentication.provider.simple_form.default" has a de [04:39:32][Ant output] [exec] [exec] pendency on a non-existent service "security.user.provider.concrete.carrier [04:39:32][Ant output] [exec] [exec] User". ````` Problem has occurred with this commit line: fbd9f88#diff-2be909961a57bf75fbb600c1f5fc46e3R320 Issue fixes with this PR. Commits ------- 6d23c8c #21809 [SecurityBundle] bugfix: if security provider's name contains upper cases then container didn't compile

* 2.7: removed test that does not test anything fixed tests #21809 [SecurityBundle] bugfix: if security provider's name contains upper cases then container didn't compile [Validator] fix URL validator to detect non supported chars according to RFC 3986 [Security] Fixed roles serialization on token from user object

* 2.8: removed test that does not test anything fixed tests #21809 [SecurityBundle] bugfix: if security provider's name contains upper cases then container didn't compile [WebProfilerBundle] Fix for CSS attribute at Profiler Translation Page Set Date header in Response constructor already [Validator] fix URL validator to detect non supported chars according to RFC 3986 [Security] Fixed roles serialization on token from user object

* 3.2: [Bridge\Doctrine] Fix change breaking doctrine-bundle test suite [WebProfilerBundle] Include badge status in translation tabs [FrameworkBundle] Cache pool clear command requires at least 1 pool [HttpFoundation][bugfix] should always be initialized MockArraySessionStorage: updated phpdoc for $bags so that IDE autocompletion would work normalize paths before making them relative removed test that does not test anything fixed tests #21809 [SecurityBundle] bugfix: if security provider's name contains upper cases then container didn't compile [WebProfilerBundle] Fix for CSS attribute at Profiler Translation Page Set Date header in Response constructor already [Validator] fix URL validator to detect non supported chars according to RFC 3986 [Security] Fixed roles serialization on token from user object

* 2.8: removed test that does not test anything fixed tests symfony#21809 [SecurityBundle] bugfix: if security provider's name contains upper cases then container didn't compile [WebProfilerBundle] Fix for CSS attribute at Profiler Translation Page Set Date header in Response constructor already [Validator] fix URL validator to detect non supported chars according to RFC 3986 [Security] Fixed roles serialization on token from user object

* 3.2: [Bridge\Doctrine] Fix change breaking doctrine-bundle test suite [WebProfilerBundle] Include badge status in translation tabs [FrameworkBundle] Cache pool clear command requires at least 1 pool [HttpFoundation][bugfix] should always be initialized MockArraySessionStorage: updated phpdoc for $bags so that IDE autocompletion would work normalize paths before making them relative removed test that does not test anything fixed tests symfony#21809 [SecurityBundle] bugfix: if security provider's name contains upper cases then container didn't compile [WebProfilerBundle] Fix for CSS attribute at Profiler Translation Page Set Date header in Response constructor already [Validator] fix URL validator to detect non supported chars according to RFC 3986 [Security] Fixed roles serialization on token from user object

xabbuh added Bug SecurityBundle Unconfirmed labels Mar 1, 2017

carsonbot added the Status: Needs Review label Mar 1, 2017

xabbuh added this to the 3.3 milestone Mar 1, 2017

antanas-arvasevicius pushed a commit to antanas-arvasevicius/symfony that referenced this issue Mar 1, 2017

symfony#21809 [SecurityBundle] bugfix: if security provider's name co…

0329b73

…ntains upper cases then container didn't compile

antanas-arvasevicius mentioned this issue Mar 1, 2017

#21809 [SecurityBundle] bugfix: if security provider's name contains upper cases then container didn't compile #21810

Closed

xabbuh mentioned this issue Mar 1, 2017

Revert "[SecurityBundle] only pass relevant user provider" #21811

Merged

antanas-arvasevicius pushed a commit to antanas-arvasevicius/symfony that referenced this issue Mar 1, 2017

symfony#21809 [SecurityBundle] bugfix: if security provider's name co…

7625f9e

…ntains upper cases then container didn't compile

antanas-arvasevicius pushed a commit to antanas-arvasevicius/symfony that referenced this issue Mar 1, 2017

symfony#21809 [SecurityBundle] bugfix: if security provider's name co…

e0107d0

…ntains upper cases then container didn't compile

fabpot closed this as completed Mar 1, 2017

fabpot pushed a commit that referenced this issue Mar 23, 2017

#21809 [SecurityBundle] bugfix: if security provider's name contains …

6d23c8c

…upper cases then container didn't compile

This was referenced Apr 4, 2017

Release v2.7.26 #22263

Merged

Release v2.8.19 #22284

Merged

Release v3.2.7 #22293

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[SecurityBundle] something is broken after recent commits #21809

[SecurityBundle] something is broken after recent commits #21809

antanas-arvasevicius commented Mar 1, 2017 •

edited by stof

Loading

antanas-arvasevicius commented Mar 1, 2017

xabbuh commented Mar 1, 2017

antanas-arvasevicius commented Mar 1, 2017

antanas-arvasevicius commented Mar 1, 2017

xabbuh commented Mar 1, 2017

mvrhov commented Mar 1, 2017

antanas-arvasevicius commented Mar 1, 2017

antanas-arvasevicius commented Mar 1, 2017

xabbuh commented Mar 1, 2017

xabbuh commented Mar 1, 2017

[SecurityBundle] something is broken after recent commits #21809

[SecurityBundle] something is broken after recent commits #21809

Comments

antanas-arvasevicius commented Mar 1, 2017 • edited by stof Loading

antanas-arvasevicius commented Mar 1, 2017

xabbuh commented Mar 1, 2017

antanas-arvasevicius commented Mar 1, 2017

antanas-arvasevicius commented Mar 1, 2017

xabbuh commented Mar 1, 2017

mvrhov commented Mar 1, 2017

antanas-arvasevicius commented Mar 1, 2017

antanas-arvasevicius commented Mar 1, 2017

xabbuh commented Mar 1, 2017

xabbuh commented Mar 1, 2017

antanas-arvasevicius commented Mar 1, 2017 •

edited by stof

Loading