Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[YAML] Parser doesn't understand properly lines with trailing spaces #22193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
lcobucci opened this issue Mar 28, 2017 · 2 comments
Closed

[YAML] Parser doesn't understand properly lines with trailing spaces #22193

lcobucci opened this issue Mar 28, 2017 · 2 comments
Labels
Bug Status: Needs Review Yaml
Milestone
3.3

Comments

@lcobucci
Copy link
Contributor

Q A
Bug report? yes
Feature request? no
BC Break report? yes
RFC? no
Symfony version 3.3-dev

As mentioned on #22067 (comment) the last commit on the yaml component breaks the parser for that scenario.
@SirWaddles SirWaddles mentioned this issue Mar 29, 2017
Merged
@fabpot
Copy link
Member

fabpot commented Mar 29, 2017

ping @nicolas-grekas

@jsamouh jsamouh mentioned this issue Mar 29, 2017
Merged
@jsamouh
Copy link
Contributor

jsamouh commented Mar 29, 2017

@fabpot @nicolas-grekas , I create a PR, it missed rtrim method.
I did the PR based on master

@xabbuh xabbuh added this to the 3.3 milestone Mar 29, 2017
@lcobucci lcobucci mentioned this issue Mar 31, 2017
Closed
fabpot added a commit that referenced this issue Mar 31, 2017
@fabpot
bug #22216 [Component] [Yaml] [Parser] : can parse with trailing spac…
19a9b2f 
…e as 2.8 (jordscream)

This PR was merged into the 3.3-dev branch.

Discussion
----------

[Component] [Yaml] [Parser] :  can parse with trailing space as 2.8

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no <!-- don't forget updating UPGRADE-*.md files -->
| Tests pass?   | yes
| Fixed tickets | #22193
| License       | MIT
| Doc PR        | symfony/symfony-docs

Missing rtrim method in line to parse as the version 2.8 does

Commits
-------

ce3d5ab [Component] [Yaml] [Parser] :  can parse with trailing space as 2.8
@fabpot fabpot closed this as completed Mar 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Status: Needs Review Yaml
Projects
None yet
Milestone
3.3
Development

No branches or pull requests
6 participants
@fabpot @javiereguiluz @lcobucci @jsamouh @xabbuh @carsonbot