-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[Process] Some tests fail on Windows #22556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I can't reproduce on appveyor, see https://ci.appveyor.com/project/fabpot/symfony/build/1.0.21543: this doesn't fail for the Process component. Are these errors predictable on your machine? Can you please try to investigate a bit further where this might come from? |
…rekas) This PR was merged into the 3.2 branch. Discussion ---------- [appveyor][3.x] Run the test suite on PHP 7.1 | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | let's see | Fixed tickets | #22556 | License | MIT | Doc PR | - Commits ------- 51b82f5 [appveyor][3.x] Run the test suite on PHP 7.1
@nicolas-grekas |
@nicolas-grekas
All of them pass when I comment the whole condition here https://github.com/symfony/symfony/blob/master/src/Symfony/Component/Process/Pipes/AbstractPipes.php#L123 Also PhpProcessTest was also failing but I already fixed it inside #22613 as I mentioned. |
…ntains space (maryo) This PR was merged into the 3.3-dev branch. Discussion ---------- [Process] Fix incorrectly calling PHP process when path contains space | Q | A | ------------- | --- | Branch? | master | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #22556 | License | MIT I have PHP installed at "D:\Program Files\PHP" which contains a space. `PhpExecutableFinder` found it but then `PhpProcess` splitted the path by space. This PR fixes it. I wanted to write a test but I don't know ho to do it properly since it is dependent on the location where PHP is installed and I can't even mock `PhpExecutableFinder` because it is hardcoded dependency and an implementation detail. Commits ------- 9c08109 Fix incorrectly calling PHP process on Windows when path contains space
@maryo Is that the correct spot in AbstractPipes you are commenting? Doing that seems to make no difference on my machine. I can confirm the same test failures for me in PhpProcess on Windows 10 with PHP 7.1. I can get mine to work slightly further by modifying Process to use powershell.exe instead of cmd.exe. This results in slightly garbled output (probably need to futz with powershell params). Another thing that makes it pass is setting bypass_shell to false and then adjusting the quotes for the command (Though this causes all sorts of other failures elsewhere and obviously isn't a solution, lack of PID, etc). Though that may help provide hints about what's going wrong. |
I'm closing because this is transient, thus impossible to fix. |
Some tests of the process component fail on my machine - x64 Windows 10, PHP 7.1.4
The text was updated successfully, but these errors were encountered: