[RFC] Deprecate the web_profiler.position option #23528
Comments
|
I'm +1 too for deprecating it if we're sure it doesn't provide added value. If I remember well I had to move the toolbar at the top once because I was working on a page with an infinite scroll and the toolbar at the bottom was annoying in this case. |
|
IIRC the use case @hhamon mentions was the reason why we rejected this idea in the past. However, how hard would it be to write custom CSS that does the same without the need for this option? |
|
I can't understand why you can't use the web profiler in a page with "infinite scroll". This "feature" makes impossible to achieve the footer of the page, because the page always adds more contents ... but the debug toolbar is fixed at the bottom of the browser window. You can click on it without having to do any scroll. Moving the cursor over the debug toolbar won't make the page add more contents. |
|
👍 if it removes code and help maintenance |
|
IIRC, it was introduced to help display the toolbar on mobile, where having it on top is "better"/easier/worked (don't remember exactly). |
…iluz) This PR was squashed before being merged into the 3.4 branch (closes #24080). Discussion ---------- Deprecated the web_profiler.position option | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | no <!-- don't forget updating src/**/CHANGELOG.md files --> | BC breaks? | no | Deprecations? | yes | Tests pass? | yes | Fixed tickets | #23528 | License | MIT | Doc PR | - Related to #23728, which removes the feature for Symfony 4.0. Commits ------- 53387b4 Deprecated the web_profiler.position option
…r.position option (javiereguiluz) This PR was merged into the 4.0-dev branch. Discussion ---------- [WebProfilerBundle] Removed the deprecated web_profiler.position option | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | yes | Tests pass? | yes | Fixed tickets | #23528 | License | MIT | Doc PR | - This PR shows the things we could remove if we accept #23528. If it's accepted, I'd create the PR for 3.4 deprecating the feature instead of removing it. Commits ------- cafdf2b [WebProfilerBundle] Deprecated the web_profiler.position option
…viereguiluz) This PR was squashed before being merged into the 3.4 branch (closes symfony#24080). Discussion ---------- Deprecated the web_profiler.position option | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | no <!-- don't forget updating src/**/CHANGELOG.md files --> | BC breaks? | no | Deprecations? | yes | Tests pass? | yes | Fixed tickets | symfony#23528 | License | MIT | Doc PR | - Related to symfony#23728, which removes the feature for Symfony 4.0. Commits ------- 53387b4 Deprecated the web_profiler.position option
This config option allows to display the debug toolbar at the top of the browser window instead of the default bottom position.
In the past we required this option because the old profiler displayed the toolbar at the top ... but the new profiler no longer needs it because it doesn't display the toolbar.
Although this may look as a small option, it requires some code to manage it:
positionoption inweb_profilerweb_profiler.debug_toolbar.positionNow that we don't need this option for ourselves, I propose to deprecate it in 3.4 and remove it in 4.0.
The text was updated successfully, but these errors were encountered: