Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[HttpFoundation] copy-paste in HttpFoundation #2685

Closed
@andrewtch

Description

@andrewtch

Well, when writing / implementing wildcard support in pull request #2684 I noticed there are basically the following class hierarchy

HeaderBag
  | - ReponseHeaderBag
ParameterBag
  | - FileBag
  | - ServerBag
Session

appearing there are three basic classes (HeaderBag, ParameterBag, Session) sharing the same functionality (add(), replace(), all(), keys(), replace(), get(), set(), has(), remove()).

Don't you think this should be refactored to some base (even abstract) class, something like AbstractBag to avoid repetitions? If yes, i can work on that.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions