Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Documentation about ClassDiscriminatorResolver unclear #27451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
thasmo opened this issue May 31, 2018 · 3 comments
Closed

Documentation about ClassDiscriminatorResolver unclear #27451

thasmo opened this issue May 31, 2018 · 3 comments
Assignees
@fabpot
Labels
Serializer

Comments

@thasmo
Copy link

thasmo commented May 31, 2018 •
edited
Loading

Symfony version(s) affected: 4.1

Description
Documentation mentions the use of ClassDiscriminatorResolver which is absent from Symfony 4.1 so either the docs need an update or ClassDiscriminatorResolver is missing from Symfony 4.1.
@Tobion
Copy link
Contributor

Tobion commented May 31, 2018

https://github.com/symfony/symfony/blob/4.1/src/Symfony/Component/Serializer/Mapping/ClassDiscriminatorResolverInterface.php
The api docs seems to be outdated as those classes are missing: https://api.symfony.com/4.1/Symfony/Component/Serializer/Mapping.html

@sroze
Copy link
Contributor

sroze commented Jun 1, 2018

@thasmo fancy sending a pull-request on the documentation to refers to the interface ( ClassDiscriminatorResolverInterface) instead? We'll see in the core team how we can fix the issue that the file don't exists (but should).

@sroze sroze mentioned this issue Jun 3, 2018
Merged
@sroze
Copy link
Contributor

sroze commented Jun 3, 2018

Documentation PR is here: symfony/symfony-docs#9873
The missing classes in the API documentation will be handled by @fabpot :)

javiereguiluz added a commit to symfony/symfony-docs that referenced this issue Jun 4, 2018
@javiereguiluz
minor #9873 [Serializer] Fix the interface/abstract classes documenta…
0401973 
…tion (sroze)

This PR was merged into the 4.1 branch.

Discussion
----------

[Serializer] Fix the interface/abstract classes documentation

See symfony/symfony#27451

Commits
-------

af9726d Fix the interface/abstract classes documentation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fabpot fabpot

Labels
Serializer
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@fabpot @thasmo @nicolas-grekas @Tobion @sroze