Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[WebProfilerBundle] Dumps unreadable #28935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ro0NL opened this issue Oct 20, 2018 · 4 comments
Closed

[WebProfilerBundle] Dumps unreadable #28935

ro0NL opened this issue Oct 20, 2018 · 4 comments
Labels
Bug Status: Needs Review WebProfilerBundle

Comments

@ro0NL
Copy link
Contributor

ro0NL commented Oct 20, 2018 •
edited
Loading

Symfony version(s) affected: 4.2 i guess

Description

image

(white text on white background)

IMHO the green is too bright also
@ogizanagi
Copy link
Contributor

Looks like the dark theme with a transparent background instead of the light one usually defined by the profiler styles.

@ro0NL
Copy link
Contributor Author

ro0NL commented Oct 22, 2018

So related to #28932 maybe

@nicolas-grekas nicolas-grekas added this to the 4.2 milestone Nov 11, 2018
@nicolas-grekas
Copy link
Member

Anyone willing to work on this?

@nicolas-grekas nicolas-grekas mentioned this issue Nov 11, 2018
Closed
@ro0NL ro0NL mentioned this issue Nov 12, 2018
Merged
@nicolas-grekas nicolas-grekas removed this from the 4.2 milestone Nov 12, 2018
nicolas-grekas added a commit to nicolas-grekas/symfony that referenced this issue Nov 12, 2018
@nicolas-grekas
bug symfony#29184 [WebProfilerBundle] Fix theme settings (ro0NL)
6eb5f93 
This PR was squashed before being merged into the 4.2-dev branch (closes symfony#29184).

Discussion
----------

[WebProfilerBundle] Fix theme settings

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | symfony#28932 symfony#28935
| License       | MIT
| Doc PR        | symfony/symfony-docs#... <!-- required for new features -->

Commits
-------

8fbe85c [WebProfilerBundle] Fix theme settings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Status: Needs Review WebProfilerBundle
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@nicolas-grekas @ro0NL @xabbuh @ogizanagi @carsonbot