Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Messenger] [Redis] options object is not used #33425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
marcoreni opened this issue Sep 2, 2019 · 2 comments
Closed

[Messenger] [Redis] options object is not used #33425

marcoreni opened this issue Sep 2, 2019 · 2 comments
Labels
Bug Messenger Status: Needs Review

Comments

@marcoreni
Copy link

Symfony version(s) affected: 4.3.4

Description
According to the documentation, Redis should be configurable using the options object, but this seems not to work.

How to reproduce

framework:
  messenger:
    transports:
      mytransport:
        dsn: "redis://localhost:6379"
        options:
          stream: "stream-name"
          group: "worker-group"
          auto_setup: true

Messages should be posted into the stream-name stream, and consumed using worker-group group. However, messages are posted into messages stream, and consumed using symfony group name - you can check this on redis-cli: XPENDING messages worker-group yields "NOGROUP No such key 'messages' or consumer group 'worker-group'".

Using querystring parameters to configure the same options works just fine.
@tomdupont
Copy link

I can verify it is still a problem in 4.4.x-dev.

@chalasr chalasr mentioned this issue Oct 17, 2019
Merged
@chalasr
Copy link
Member

chalasr commented Oct 17, 2019

See #34017

nicolas-grekas added a commit that referenced this issue Oct 22, 2019
@nicolas-grekas
bug #34017 [Messenger] Fix ignored options in redis transport (chalasr)
13e15e2 
This PR was merged into the 4.3 branch.

Discussion
----------

[Messenger] Fix ignored options in redis transport

| Q             | A
| ------------- | ---
| Branch?       | 4.3
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #33425
| License       | MIT
| Doc PR        | -

Also fixes redis authentication failure handling (inline with invalid db index handling, borrowed from symfony/cache).
/cc @alexander-schranz

Commits
-------

c83ff94 [Messenger] Fix ignored options in redis transport
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Messenger Status: Needs Review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@javiereguiluz @nicolas-grekas @marcoreni @chalasr @carsonbot @tomdupont