Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[FrameworkBundle] Improve the sorting of tagged services #33716

Closed
@javiereguiluz

Description

@javiereguiluz

Description
In #33128 @krome162504 contributed a nice improvement to sort tagged services. I think we could improve it a bit more to sort the tags inside each service too.

Example
This is the current result of sorting some services:

<container>
  <definition id="definition_3" class="Full\Qualified\Class3" public="true" synthetic="true" lazy="false" shared="true" abstract="false" autowired="false" autoconfigured="false" file="/path/to/file">
    <tags>
      <tag name="tag1">
        <parameter name="attr1">val1</parameter>
        <parameter name="attr2">val2</parameter>
        <parameter name="priority">0</parameter>
      </tag>
      <tag name="tag1">
        <parameter name="attr3">val3</parameter>
        <parameter name="priority">40</parameter>
      </tag>
    </tags>
  </definition>
  <!-- ... -->

Given that 40 has higher priority than 0, I think the result should really be this:

<container>
  <definition id="definition_3" class="Full\Qualified\Class3" public="true" synthetic="true" lazy="false" shared="true" abstract="false" autowired="false" autoconfigured="false" file="/path/to/file">
    <tags>
      <tag name="tag1">
        <parameter name="attr3">val3</parameter>
        <parameter name="priority">40</parameter>
      </tag>
      <tag name="tag1">
        <parameter name="attr1">val1</parameter>
        <parameter name="attr2">val2</parameter>
        <parameter name="priority">0</parameter>
      </tag>
    </tags>
  </definition>
  <!-- ... -->

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions