Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[WebProfilerBundle] BC break in 4.4.11 - debug bar won't load #37655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
keksa opened this issue Jul 24, 2020 · 2 comments
Closed

[WebProfilerBundle] BC break in 4.4.11 - debug bar won't load #37655

keksa opened this issue Jul 24, 2020 · 2 comments

Comments

@keksa
Copy link
Contributor

keksa commented Jul 24, 2020

Symfony version(s) affected: 4.4.11

Description
Debug bar won't load anymore for our use case after changes introduces in #37576 because it's blocked by CORS.

We're using a setup, where we have 2 application modules accessible behind a proxy. The proxy is running at proxy.test and the modules are accessible at proxy.test/foo and proxy.test/bar. The modules itself are running at their own internal URLs -> foo.test and bar.test.

It worked before with the relative URL, because the /foo/_wdt/66dc93 was loaded by browser as proxy.test/foo/_wdt/66dc93, but now it's loaded as foo.test/foo/_wdt/66dc93.

It's very much possible this can be solved by some configuration on our part, but IMO this is BC break and as such should not be released in patch version.

@keksa keksa added the Bug label Jul 24, 2020
@stof
Copy link
Member

stof commented Jul 24, 2020

Well, this means that any place generating absolute URLs in your project is actually broken, right ?

I suggest instead to configure your project to consider your proxy as a trusted proxy and ensure that the proxy sets the forwarded headers properly, so that Symfony knows about proxy.test being the public URL. This will fix all generation of absolute URLs in your project.

@keksa
Copy link
Contributor Author

keksa commented Jul 24, 2020

Hi @stof, yes, you're absolutely correct and I'll look into it, thank you for the pointer. 🙂 Since all absolute URL generation is broken in our case, I guess this issue can be closed as it's not really BC in the end. Did not think to check that, as we simply don't use it anywhere.

@keksa keksa closed this as completed Jul 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants