Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Why is not REQUEST_TIME_FLOAT set by default when constructing a Request object? #38019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
imanoleguskiza opened this issue Sep 1, 2020 · 1 comment
Closed

Why is not REQUEST_TIME_FLOAT set by default when constructing a Request object? #38019

imanoleguskiza opened this issue Sep 1, 2020 · 1 comment
Labels
HttpFoundation

Comments

@imanoleguskiza
Copy link

When creating a Symfony\Component\HttpFoundation\Request object several server parameters are set, including REQUEST_TIME. However, the float equivalent REQUEST_TIME_FLOAT is not set. I tried looking for documentation about this to no avail. Is this intentional? Could we open a feature request to include it?
@xabbuh
Copy link
Member

xabbuh commented Sep 1, 2020

I can imagine that REQUEST_TIME_FLOAT wasn't a thing when the class was initially written (this field was added in PHP 5.4).

@ctasada ctasada mentioned this issue Jan 23, 2021
Closed
@ctasada ctasada mentioned this issue Jan 31, 2021
Merged
fabpot added a commit that referenced this issue Feb 5, 2021
@fabpot
bug #40043 [HttpFoundation] Setting REQUEST_TIME_FLOAT when constru…
2eddb51 
…cting a Request object (ctasada)

This PR was merged into the 4.4 branch.

Discussion
----------

[HttpFoundation] Setting `REQUEST_TIME_FLOAT` when constructing a Request object

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #38019
| License       | MIT
| Doc PR        | -

When creating a new Request object `REQUEST_TIME_FLOAT` was not set by default.

Replaces broken 39952 PR :(

Commits
-------

c52c1e0 [HttpFoundation] Setting `REQUEST_TIME_FLOAT` when constructing a Request object
@fabpot fabpot closed this as completed Feb 5, 2021
@ste93cry ste93cry mentioned this issue Mar 6, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
HttpFoundation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[HttpFoundation] Setting REQUEST_TIME_FLOAT when constructing a Request object ctasada/symfony
3 participants
@fabpot @xabbuh @imanoleguskiza