[DependencyInjection] Non-existent "inner" service when decorated and autowired #43272

BafS · 2021-10-01T10:15:55Z

Symfony version(s) affected: > v5.3.4

Description

There is a breaking change since DependencyInjection was updated (patch version !). It works fine from v5.0.0 to v5.3.4 but newer versions have a breaking change with decorated services. It seems it was introduced #42815 because of the pass order.

How to reproduce

<?php
namespace Test;
require_once 'vendor/autoload.php';

$containerBuilder = new \Symfony\Component\DependencyInjection\ContainerBuilder();

class Foo {}
class Bar extends Foo {}
class A {
    public function __construct(Foo $foo) {}
}

$containerBuilder->register('foo', Foo::class);

$containerBuilder->register('bar', Bar::class)->setDecoratedService('foo');
$containerBuilder->setAlias(Foo::class, 'bar.inner');

$containerBuilder->register(A::class)->setAutowired(true);

$containerBuilder->compile();

This code works for versions <= v5.3.4 and is breaking for versions > v5.3.4.

Error: PHP Fatal error: Uncaught Symfony\Component\DependencyInjection\Exception\ServiceNotFoundException: You have requested a non-existent service "bar.inner". in /.../vendor/symfony/dependency-injection/ContainerBuilder.php:979

Possible Solution

Change the pass order that was changed in #42815 (but if I follow correctly it was made to fix #42791 which was made to fix #42347 because autowire arguments were changed in #40406).

The text was updated successfully, but these errors were encountered:

stof · 2021-10-01T10:41:59Z

Can you provide the stack trace of the exception you get ?

BafS · 2021-10-01T10:55:54Z

Sure!

Fatal error: Uncaught Symfony\Component\DependencyInjection\Exception\ServiceNotFoundException: You have requested a non-existent service "bar.inner". in /.../vendor/symfony/dependency-injection/ContainerBuilder.php:979
Stack trace:
#0 /.../vendor/symfony/dependency-injection/ContainerBuilder.php(1011): Symfony\Component\DependencyInjection\ContainerBuilder->getDefinition('bar.inner')
#1 /.../vendor/symfony/dependency-injection/Compiler/AutowirePass.php(336): Symfony\Component\DependencyInjection\ContainerBuilder->findDefinition('bar.inner')
#2 /.../vendor/symfony/dependency-injection/Compiler/AutowirePass.php(259): Symfony\Component\DependencyInjection\Compiler\AutowirePass->getAutowiredReference(Object(Symfony\Component\DependencyInjection\TypedReference))
#3 /.../vendor/symfony/dependency-injection/Compiler/AutowirePass.php(290): Symfony\Component\DependencyInjection\Compiler\AutowirePass->Symfony\Component\DependencyInjection\Compiler\{closure}()
#4 /.../vendor/symfony/dependency-injection/Compiler/AutowirePass.php(180): Symfony\Component\DependencyInjection\Compiler\AutowirePass->autowireMethod(Object(ReflectionMethod), Array, true)
#5 /.../vendor/symfony/dependency-injection/Compiler/AutowirePass.php(133): Symfony\Component\DependencyInjection\Compiler\AutowirePass->autowireCalls(Object(ReflectionClass), true, true)
#6 /.../vendor/symfony/dependency-injection/Compiler/AutowirePass.php(78): Symfony\Component\DependencyInjection\Compiler\AutowirePass->doProcessValue(Object(Symfony\Component\DependencyInjection\Definition), true)
#7 /.../vendor/symfony/dependency-injection/Compiler/AbstractRecursivePass.php(81): Symfony\Component\DependencyInjection\Compiler\AutowirePass->processValue(Object(Symfony\Component\DependencyInjection\Definition), true)
#8 /.../vendor/symfony/dependency-injection/Compiler/AutowirePass.php(109): Symfony\Component\DependencyInjection\Compiler\AbstractRecursivePass->processValue(Array, true)
#9 /.../vendor/symfony/dependency-injection/Compiler/AutowirePass.php(78): Symfony\Component\DependencyInjection\Compiler\AutowirePass->doProcessValue(Array, true)
#10 /.../vendor/symfony/dependency-injection/Compiler/AbstractRecursivePass.php(46): Symfony\Component\DependencyInjection\Compiler\AutowirePass->processValue(Array, true)
#11 /.../vendor/symfony/dependency-injection/Compiler/AutowirePass.php(60): Symfony\Component\DependencyInjection\Compiler\AbstractRecursivePass->process(Object(Symfony\Component\DependencyInjection\ContainerBuilder))
#12 /.../vendor/symfony/dependency-injection/Compiler/Compiler.php(91): Symfony\Component\DependencyInjection\Compiler\AutowirePass->process(Object(Symfony\Component\DependencyInjection\ContainerBuilder))
#13 /.../vendor/symfony/dependency-injection/ContainerBuilder.php(744): Symfony\Component\DependencyInjection\Compiler\Compiler->compile(Object(Symfony\Component\DependencyInjection\ContainerBuilder))
#14 /.../bug.php(20): Symfony\Component\DependencyInjection\ContainerBuilder->compile()
#15 {main}
  thrown in /.../vendor/symfony/dependency-injection/ContainerBuilder.php on line 979

xabbuh · 2021-10-01T11:25:47Z

Do you still see the error with the latest patch release?

BafS · 2021-10-01T13:00:26Z

Yes with version v5.3.8 @xabbuh

BafS · 2021-10-01T13:59:08Z

Why was it closed?
If it was not clear, yes, I do have the bug with version 5.3.8 and 5.3.x-dev e39c344 too.

nicolas-grekas · 2021-10-01T14:03:05Z

Oops sorry I read too fast as this being fixed in 5.3.8

xabbuh · 2021-10-01T14:03:16Z

Can you create a small example application that allows to reproduce your issue?

BafS · 2021-10-01T14:17:46Z

I did a minimal snippet in the description to reproduce the issue.
You simply need to install symfony/dependency-injection to be able to reproduce.

composer req "symfony/dependency-injection:^5.3"
php bug.php

Okhoshi · 2021-10-01T16:12:05Z

If I may, I have the impression that all these DI issues @BafS mentioned in the OP are due to the various changes in CompilerPass ordering.

If I sum up:

AutowirePass needs to run after the DecoratorPass for the described behaviour to work.
DecoratorPass needs to run after the ServiceLocatorTagPass for the behaviour in Fix ServiceLocator indexing when service is decorated #42347 to work.
ServiceLocatorTagPass needs to run after the AutowirePass to support the attribute support added in [DependencyInjection] Autowire arguments using attributes #40406.

We end up in a cyclic dependency since #40406 because the attribute support was implemented as part of the AutowirePass (which was surely the right call at the time, but maybe it should have been released with 5.4 :D).
However, since then, #42039 added a simplified way to do autoconfiguration based on Attributes.

Could #40406 be reimplemented using the AttributeAutoconfigurationPass, so that we can restore the CompilerPass ordering that was in place before v5.3.4 ?

BafS · 2021-10-11T12:53:20Z

I agree with @Okhoshi, could we restore the compiler pass order like it was in 5.3.4?
There were multiple patches committed to fix issues related to the change in the order and there is still some issue. We are still stuck in version v5.3.4 because next versions are not compatible anymore.

nicolas-grekas · 2021-10-17T06:51:47Z

If we restore the compiler pass pre-#42815, then we should find another fix for #42791 before. Anyone up to digging this?

Okhoshi · 2021-10-17T08:23:00Z

I would be happy to propose a PR giving a more concrete overview of my suggestion.

… attributes (Okhoshi) This PR was merged into the 5.3 branch. Discussion ---------- [DependencyInjection] Fix autowiring tagged arguments from attributes | Q | A | ------------- | --- | Branch? | 5.3 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix #43272 | License | MIT | Doc PR | no Reimplement #40406 with `AttributeAutoconfigurationPass` to avoid the BC following the change in `CompilerPass` ordering in `PassConfig`. Also revert the various fix made in an attempt to recover the BC introduced by #40406. ~Note: `5.4` branch was needed because `AttributeAutoconfigurationPass` is not handling parameters in 5.3~ To-do: - [x] Add a test to cover the breakage presented in #43272 Commits ------- 4c7566f [DependencyInjection] Fix autowiring tagged arguments from attributes

BafS added the Bug label Oct 1, 2021

carsonbot added DependencyInjection Status: Needs Review labels Oct 1, 2021

xabbuh added the Status: Waiting feedback label Oct 1, 2021

nicolas-grekas closed this as completed Oct 1, 2021

nicolas-grekas reopened this Oct 1, 2021

Okhoshi mentioned this issue Oct 19, 2021

[DependencyInjection] Fix autowiring tagged arguments from attributes #43579

Merged

1 task

Okhoshi added a commit to Okhoshi/symfony that referenced this issue Oct 20, 2021

[DependencyInjection] Create test for symfony#43272

15aa960

nicolas-grekas closed this as completed Oct 26, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

[DependencyInjection] Non-existent "inner" service when decorated and autowired #43272

[DependencyInjection] Non-existent "inner" service when decorated and autowired #43272

BafS commented Oct 1, 2021

stof commented Oct 1, 2021

Uh oh!

BafS commented Oct 1, 2021

Uh oh!

xabbuh commented Oct 1, 2021

Uh oh!

BafS commented Oct 1, 2021

Uh oh!

BafS commented Oct 1, 2021

Uh oh!

nicolas-grekas commented Oct 1, 2021

Uh oh!

xabbuh commented Oct 1, 2021

Uh oh!

BafS commented Oct 1, 2021 •

edited

Loading

Uh oh!

Okhoshi commented Oct 1, 2021

Uh oh!

BafS commented Oct 11, 2021 •

edited

Loading

Uh oh!

nicolas-grekas commented Oct 17, 2021

Uh oh!

Okhoshi commented Oct 17, 2021

Uh oh!

Uh oh!

[DependencyInjection] Non-existent "inner" service when decorated and autowired #43272

[DependencyInjection] Non-existent "inner" service when decorated and autowired #43272

Comments

BafS commented Oct 1, 2021

stof commented Oct 1, 2021

Uh oh!

BafS commented Oct 1, 2021

Uh oh!

xabbuh commented Oct 1, 2021

Uh oh!

BafS commented Oct 1, 2021

Uh oh!

BafS commented Oct 1, 2021

Uh oh!

nicolas-grekas commented Oct 1, 2021

Uh oh!

xabbuh commented Oct 1, 2021

Uh oh!

BafS commented Oct 1, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Okhoshi commented Oct 1, 2021

Uh oh!

BafS commented Oct 11, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nicolas-grekas commented Oct 17, 2021

Uh oh!

Okhoshi commented Oct 17, 2021

Uh oh!

BafS commented Oct 1, 2021 •

edited

Loading

BafS commented Oct 11, 2021 •

edited

Loading