-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[Console] Completion version should not use application's version #44733
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Labels
Comments
Thank you for this issue. |
Friendly reminder that this issue exists. If I don't hear anything I'll close this. |
This one is still valid. @wouterj do you plan to work on this ? |
Proposed a fix: #46901 |
fabpot
added a commit
that referenced
this issue
Jul 15, 2022
… (wouterj) This PR was merged into the 6.2 branch. Discussion ---------- [Console] Be explicit about the completion API version | Q | A | ------------- | --- | Branch? | 6.2 | Bug fix? | yes | New feature? | yes | Deprecations? | no | Tickets | Fix #44733 | License | MIT | Doc PR | n/a Using the application version is wrong, especially for standalone apps like PHPStan. The completion API is not bound to change on a PHPStan version upgrade, but instead only when something in symfony/console changes. I suggest having an explicit completion API version, that we can increase once we change something in the API (and thus require an update of the shell scripts). Commits ------- b19eb38 [Console] Be explicit about the completion API version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Symfony version(s) affected
5.4
Description
From #44729
Possible fixes:
From @GromNaN:
From @stof:
Let's investigate how hard dev versions are here. That seems the most simple solution here.
The text was updated successfully, but these errors were encountered: