[Console] Be explicit about the completion API version #46901
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GromNaN
approved these changes
Jul 11, 2022
Using the application version is wrong, especially for standalone apps like PHPStan. The completion API is not bound to change on a PHPStan version upgrade, but instead only when something in symfony/console changes.
1acd7e2 to
b19eb38
Compare
fabpot
approved these changes
Jul 15, 2022
|
Thank you @wouterj. |
GromNaN
reviewed
Jul 21, 2022
| // $this->log($message); | ||
| // "symfony" must be kept for compat with the shell scripts generated by Symfony Console 5.4 - 6.1 | ||
| $version = $input->getOption('symfony') ? '1' : $input->getOption('api-version'); | ||
| if ($version && version_compare($version, self::COMPLETION_API_VERSION, '>=')) { |
There was a problem hiding this comment.
The comparison in wrong. Fixed in #47019
fabpot
added a commit
that referenced
this pull request
Jul 22, 2022
…NaN) This PR was merged into the 6.2 branch. Discussion ---------- [Console] Fix comparison with completion api version | Q | A | ------------- | --- | Branch? | 6.2 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix #46901 | License | MIT | Doc PR | n/a Comparison introduced in #46901 is wrong. Commits ------- 91c8c83 Fix comparison with completion api version
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the application version is wrong, especially for standalone apps like PHPStan. The completion API is not bound to change on a PHPStan version upgrade, but instead only when something in symfony/console changes.
I suggest having an explicit completion API version, that we can increase once we change something in the API (and thus require an update of the shell scripts).