Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Translator] Domain overlapse with intl #46189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
xavren opened this issue Apr 27, 2022 · 0 comments
Closed

[Translator] Domain overlapse with intl #46189

xavren opened this issue Apr 27, 2022 · 0 comments

Comments

@xavren
Copy link
Contributor

xavren commented Apr 27, 2022

Symfony version(s) affected

4.4

Description

Injecting domain to translator can induce format errors due to domain mixup

How to reproduce

With a colision in domain.yml and domain+intl-icu.yml, we got domain.yml data with intl formatter

Possible Solution

No response

Additional Context

No response

@xavren xavren added the Bug label Apr 27, 2022
nicolas-grekas added a commit that referenced this issue Aug 2, 2022
This PR was merged into the 4.4 branch.

Discussion
----------

[Translation] Fix translator overlapse

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tickets       | Fix #46189
| License       | MIT
| Doc PR        | symfony/symfony-docs#... <!-- required for new features -->
<!--
Replace this notice by a short README for your feature/bugfix.
This will help reviewers and should be a good start for the documentation.

Additionally (see https://symfony.com/releases):
 - Always add tests and ensure they pass.
 - Bug fixes must be submitted against the lowest maintained branch where they apply
   (lowest branches are regularly merged to upper ones so they get the fixes too.)
 - Features and deprecations must be submitted against the latest branch.
 - Changelog entry should follow https://symfony.com/doc/current/contributing/code/conventions.html#writing-a-changelog-entry
 - Never break backward compatibility (see https://symfony.com/bc).
-->

Commits
-------

99ca5f9 [Translator] Fix translator overlapse
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants