Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[CssSelector] Add support for :is() and :where() #48772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
stof opened this issue Dec 23, 2022 · 3 comments · Fixed by #48803
Closed

[CssSelector] Add support for :is() and :where() #48772

stof opened this issue Dec 23, 2022 · 3 comments · Fixed by #48803
Labels
CssSelector Feature Help wanted Issues and PRs which are looking for volunteers to complete them. Stalled

Comments

@stof
Copy link
Member

stof commented Dec 23, 2022

Description

https://github.com/scrapy/cssselect (the python code that was ported to create the CssSelector component) has added support for them in their 1.2.0 release.

The generated XPath will likely be the same for both cases, but the specificity computation will not.

Example

No response
@stof stof added the Help wanted Issues and PRs which are looking for volunteers to complete them. label Dec 23, 2022
@stof stof added the Feature label Dec 23, 2022
@Jean-Beru Jean-Beru mentioned this issue Dec 28, 2022
Merged
@roma84 roma84 mentioned this issue Apr 5, 2023
Closed
@carsonbot
Copy link

Thank you for this suggestion.
There has not been a lot of activity here for a while. Would you still like to see this feature?

@carsonbot
Copy link

Could I get an answer? If I do not hear anything I will assume this issue is resolved or abandoned. Please get back to me <3

@carsonbot
Copy link

Hey,

I didn't hear anything so I'm going to close it. Feel free to comment if this is still relevant, I can always reopen!

fabpot added a commit that referenced this issue Feb 3, 2024
@fabpot
feature #48803 [CssSelector] add support for :is() and :where() (Jean…
d2d36b5 
…-Beru)

This PR was squashed before being merged into the 7.1 branch.

Discussion
----------

[CssSelector] add support for :is() and :where()

| Q             | A
| ------------- | ---
| Branch?       | 7.1
| Bug fix?      | no
| New feature?  | yes
| Deprecations? | no
| Tickets       | Fix #48772
| License       | MIT
| Doc PR        | symfony/symfony-docs#17628

This PR adds support for [:is()](https://developer.mozilla.org/en-US/docs/Web/CSS/:is) and  [:where()](https://developer.mozilla.org/en-US/docs/Web/CSS/:where) pseudo-classes.

Commits
-------

c083e1d [CssSelector] add support for :is() and :where()
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CssSelector Feature Help wanted Issues and PRs which are looking for volunteers to complete them. Stalled
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[CssSelector] add support for :is() and :where() Jean-Beru/symfony
2 participants
@stof @carsonbot